Repository navigation
Conversation
The orchestrator stops re-running reds on a quiet host. Every red below is on main's code, so each is disabled now, and its issue says what it is and what ends it. Defects already on main: - process_stats: a connection park charged 0 ns to ipc and to pipe, at process_stats.rs:280 on wt/toyos-loaderlines 6e0d7da (fastest boot 480 ms) and at :263 on wt/toyos-proclife1 60ec86d. Neither branch touches the test or the charge. The existing issue takes both sightings and becomes expected-red. - lan_dhcp_lease: the test awaits the lease and asserts netd's ready line after it, but the capture ends at test-runner's ===READY===, which can come first (wt/toyos-tight 59940c4, ceilings at 1.00x). - root_candidate_malformed: wait_for_ready reads a 16550 ready marker off QEMU's log file while the loader is still writing the line, and the test got "Slot A: REFUSED, its root is" (same run). - redirty_mid_flush: the guest went silent after spawning its child (wt/toyos-proclife 6e9d6a4). The branch's own kernel change is two retired-syscall lines; the test passed at the branch's previous head and in every other kept whole-suite log. Verdicts the host's speed decided: - update_boots_the_new_kernel, update_falls_back_from_a_dying_kernel, update_floor_is_the_images_own, update_refusals_boot_the_other_slot: 15 s of silence across the firmware reset reads as a stall at load average 84, on #648's run and again on #642's. - guest_dies_with_its_harness: the owner's boot is judged at an unscaled 20 s on the host's clock. - syscall_window_nmi_controls: the spinner stops after ten seconds of the guest's clock and the storm waits for a million syscalls; starved, it made 950000. - virt_smp: an AP has 100 ms to echo, and a starved vCPU did not. src/redlist.rs's whole-name test probed `<row>_controls` against None; with syscall_window_nmi and syscall_window_nmi_controls both disabled that probe finds the second row, so it now asserts only that the probe does not find the row it extends. The old assertion reds on this table (checked: EXIT=101), the new one passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016t9wjdQkB8SH7bmfUoiy6L
Japabu
marked this pull request as ready for review
October 1, 2026 02:20
…only branch's run Both went red in 650-libcllvm-whole.log on wt/toyos-libcllvm, whose diff is userland/libc alone, at load average 66-74. - iommu_virtio_platform is a defect on main. It reads netd's claim line and netd's feature negotiation off a boot log that ends at test-runner's ===READY===, and netd starts before test-runner but speaks after it. The same race reds in two wordings on 634r2, 637r2 and 641f-r3, each on a branch that does not touch it. #639 carries a fix (d773a43). - loader_watchdog_arms timed out its boot at 132 s of wall clock, which is 10 s x 12 wide x host_scale. The console stood at "BdsDxe: starting Boot0001". Its 50-odd other runs in the kept logs passed in 6-34 s. It goes under the harness-wait issue, which now carries this sighting and 650's two update STALLs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016t9wjdQkB8SH7bmfUoiy6L
650-libcllvm-whole.log, wt/toyos-libcllvm, whose diff is userland/libc alone; load average 66-87, with the run reporting ceilings at 1.01x. - metal_sim_window_drag and usb_boot_stick_pulled timed out their boots at 21 and 22 s in the serial tail, the 20 s a phase of one guest gets. Each had the loader still printing its segments. They go under the harness-wait issue, which now also says why the run's 1.01x could not see the load. - blockd_serves_partitions: the bench passed and its process exited at 35.978 s, then no ===TEST_END=== came for 3559 s, while the kernel kept logging with every CPU idle. Either test-runner's wait on the job missed the exit's post, or logd stopped forwarding. The new issue says which evidence the next sighting needs, and names #655's poller shape as the logd reading. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016t9wjdQkB8SH7bmfUoiy6L
Collaborator
Author
|
Review of #654 at head CI: BLOCKER
NOTE
REMOVE
SEND BACK |
Japabu
added a commit
that referenced
this pull request
Oct 1, 2026
…d the defects the cut's tests found - `.claude/agents/reviewer.md`: **Growth** said tests are cut only when they test nothing, which sends back every cut the ladder makes. It now reads "a test is cut only when it tests nothing, or as **Guest tests** says", and **Guest tests** says when: a cheaper tier already holds the behaviour, named in the pull request body, or a stage of a track names it in the same diff with an exit a build or test can fail. A guest test re-argues the tiers when it is new or its behaviour changes, not on every edit. - The track carries owed work only: the verdict counts, the keep list and both cut lists go to this pull request's body, and stage M goes, its shard, duration and phase half done here and the rest naming nothing. It names its owner. The tests main redlists are not its items: each is red and its issue holds it. `late_storage_connect` stays metal, staged by its actuator rather than a plug; `https_tls13_e1000e` and `blackbox_early_panic_sealed_muted` join the rows that cover them; `metal_sim_input` and `virtio_used_ring` become host items and `query_pci_agreement` a metal one against Ubuntu's `lspci`; FPU isolation goes first in stage C; and each item whose arm needs a deleted feature or file says so. - Defects #654 recorded on main, carried whether or not their test survives: `a-ready-marker-read-off-the-16550-file-can-end-the-boot-wait-mid-line.md` (`root_candidate_malformed`), `a-test-asserts-a-daemons-line-off-a-boot-log-that-ends-before-it.md` (`lan_dhcp_lease` and `iommu_virtio_platform`, one mechanism), `an-ap-its-host-has-not-scheduled-for-100-ms-is-booted-without.md` (`virt_smp`), `blockd_serves_partitions` folded into `qemu-drops-console-output-the-harness-is-slow-to-read.md`, and `process_stats`'s two assertions with an exit a test can fail. `redirty_mid_flush`'s red was #642's own and is not carried. - `sys-debug-actions-and-two-loader-words-that-nothing-calls.md` records the ABI names the cut left with no caller. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016t9wjdQkB8SH7bmfUoiy6L
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sixteen reds on main are disabled at once, each with the issue that owns it, so a run on a loaded host stops being re-run until it is green. The fixes for the ten verdicts the host's speed decided follow in a separate pull request, which deletes their rows.
Triage
The 74-minute guard on redirty_mid_flush (120 s × 12 wide × a host_scale of 3.1) is the harness's half of the same issue as the update tests, and the fix pull request removes it.
src/redlist.rs's whole-name test probed<row>_controlsagainstNone. Withsyscall_window_nmiandsyscall_window_nmi_controlsboth disabled, that probe finds the second row, so it now asserts that the probe does not find the row it extends.Gates at 703d970
cargo test --lib redlist: EXIT=0, 5 passed (at e641eae, dc153d6 and 703d970).cargo test --test toyos-checks: EXIT=0, 28 passed (at 703d970, before the blockd row was rewrapped).left: Some(Disabled { test: "syscall_window_nmi_controls", .. }) right: None; restored.cargo run -- --ci hostis run once on the fix branch, which carries this one.Unsure
BLOCKEDpremise is not on record, because the assertion prints two of the five wait classes.🤖 Generated with Claude Code
https://claude.ai/code/session_016t9wjdQkB8SH7bmfUoiy6L