Repository navigation
The T14 rows that need the host to reach the machine under ToyOS are deleted, with the swap chain and the machine's end of the stream: 27 boots to 26 - #773
Conversation
…deleted, and the host's swap chain with them The development host reaches the T14 only while it runs Ubuntu, so the boot the host talked to was refused whole on every run: `the stream never opened`, at `6f87cdb9c` and at `c84f5fafe`. Its three rows were red with it, and a red test is fixed or deleted. Deleted: `lan_talk`, `lan_dhcp_lease` and `lan_message_delivery`; the boot `lantalkcase`, its config and its hold job; the harness's talking boots (`Arm::talk`, `Arm::nic`, the minted key, `Readback::talk`, the wire MAC); `toyos-metal`'s `--talk` and `--nic`, with the host's reader of a served log, its conversation, its ping and the lease, link and message readers. `lan_message_delivery` read only the stick, and goes too: the card's first message came 8.499 s into the last boot read, so a boot that does not talk has to be held open for it, and the one hold in the tree is the flat sleep its own issue records. The owner ruled on the swap of a running service from the host: "Delete the whole chain". So `toyos-metal --swap`, `src/metalswap.rs`, the rest of `src/metaltalk.rs`, `tests/ssh-client-host` and the build's host-judge step go, with `toyos-swap`'s readers of the supervisor's words, which only the host called. `/system/bin/swap`, the supervisor and sshserver are untouched. Two fixtures that spelled a deleted name now spell a living one. `809c33c0c` restores all of it, and `issues/the-host-cannot-reach-the-t14-while-it-runs-toyos.md` says so, with what the restored chain still owes: the six issues about that code are folded into it and closed, since their subject is gone and comes back only with it. Also closed: the cable refusal that hid the stick-only row, `lan_talk` unread since #763 (what it left unread is in the new issue), `lan_talk_host_closes`' fixed window (`29b4c651a` deleted that test) and the unattributed `swap_refused_device_fails` red, whose test and client are both gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RvnWQFcMuGqTHYhvSnTe8A
|
Review of Net lines ( BLOCKER
NOTE
Asked by the brief, no finding
SEND BACK |
… half, the swap frames that closed it, and sshserver's image key file The review of #773 found the other halves of what `d7964d26b` deleted still shipping with nothing able to reach them. The owner: "Delete the whole chain" and "If someone is blocking and its not needed then delete it ... We allow no slop". `tests/lantalkcase` was the only config whose `logkeeper` row received netstack, so `serve_network`, `bind_port`, `Carrier`, `Hub::carrier`, the network readers' count and the `stream` word of the inspect snapshot had no image to run in. They go, with `toyos_logstream::PORT`, `CARRIER` and `CARRIER_LEAVING`, the `SWAP` frames the supervisor sent logkeeper to close that listener across a swap of netstack, and `no_shipped_image_serves_the_log_on_the_network`, which guarded nothing. A reader on the machine is served as before, under one count. sshserver read `/system/etc/ssh_authorized_keys`, which only a talking boot's staging wrote. It reads `authorized_keys` under its state directory alone. `/system/bin/swap` and the supervisor's swap path stay: `system.toml` makes the desktop a login session whose shell starts `swap`, and gives a login over sshserver the same, so a shipped machine can ask for one. No test performs a swap, which the issue now says. Three more issues about the deleted halves are folded into `issues/the-host-cannot-reach-the-t14-while-it-runs-toyos.md` and closed: a netstack that dies while serving, connects turned away after logkeeper listens again, and a network reader that never reads. The review's notes are done: the network stack track owns the T14's outbound rows, the session track says it is blocked, and the usb-stick track's bullet is past tense. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RvnWQFcMuGqTHYhvSnTe8A
|
T14, On the stick, sshserver says The boot is not judged: |
|
Review of Net lines ( Round 1's BLOCKERs
Round 1's NOTEs
BLOCKERNone new. NOTE
Asked by the brief, no finding
SEND BACK |
|
Correction to my comment above (orchestrator): "what measures it is sshserver's host tests (29 passed, round 3) and CI" is false. The 29 host tests call |
The review of #773's second round: the 6 s of refused connects after a swap of netstack was filed as the deleted chain's alone, and sshserver binds again through a swapped netstack as logkeeper did; and no test at any tier reaches the file that authorizes a login, the T14's `metalcase` boot included, which leaves at `no network on this machine` before the read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RvnWQFcMuGqTHYhvSnTe8A
|
CI at
Round 2's one open BLOCKER closes on this. |
The development host reaches the T14 only while it runs Ubuntu: under ToyOS no connection it opens to the machine arrives. The owner: "we should disable or remove those tests." The tree has no disabled tests, so they are deleted, with the code only they used, on the host and on the machine.
What changed, per decision
The rows.
lan_talk,lan_dhcp_leaseandlan_message_deliveryrode one boot,lantalkcase, whichtoyos-metalrefused whole when the host's stream never opened, so all three were red onmain(the stream never opened, at6f87cdb9candc84f5fafe). Deleted with them:tests/lantalkcase, the joblan_talk_hold, the harness's talking boots (Arm::talk,Arm::nic, the minted key,Readback::talk, the wire MAC), the judges and their fixture,toyos-metal's--talkand--nicwithRefusal::TalkandRefusal::Wire, the ping (src/icmp.rs), and the boot's three rows intests/metal/lenovo-20w0003amz.toml.lan_message_deliverygoes too, though it read only the stick. The card's first message came 8.499 s into the last boot read, with its link, so a boot that does not talk has to be held open for it. The one hold in the tree islan_hold's flat sleep, whichissues/lan-hold-holds-a-boot-open-for-a-flat-twenty-seconds.mdalready records; a job that waits on the message is new machinery.The host's swap chain. The owner: "Delete the whole chain". Deleted:
toyos-metal --swapand--binary,Refusal::SwapandRefusal::Cable,src/metalswap.rs,src/metaltalk.rs,src/lan.rs,tests/ssh-client-hostand its workspaceexcludeentry,build_host_judges,ssh_client_hostandcopy_guest_programinsrc/build.rs, andtoyos-swap'sheard,outcomeandWord::is_final, which only the host called. Two fixtures that spelled a deleted name spell a living one (src/cicache.rs,src/ci.rs).The machine's end of the stream (second commit, answering the review). The owner: "If someone is blocking and its not needed then delete it ... We allow no slop".
tests/lantalkcasewas the only config whoselogkeeperrow received netstack, so its network half had no image to run in. Deleted:serve_network,bind_port,Carrier,Hub::carrier, the network readers' count and thestreamword of logkeeper's inspect snapshot;toyos_logstream::PORT,CARRIER,CARRIER_LEAVINGand theSWAPframes, with the supervisor's send of them; andno_shipped_image_serves_the_log_on_the_network, which then guarded nothing. A reader on the machine is served as before, under one count.sshserver's image key file.
/system/etc/ssh_authorized_keyswas written only by a talking boot's staging. sshserver readsauthorized_keysunder its state directory and nothing else.The swap's machine half stays.
/system/bin/swapand the supervisor's swap path are reachable on a shipped machine:system.tomlmakes the desktop a login session ([programs.compositor] login = true) whose shell listsswapinstarts, and gives a login over sshserver the same. Nothing on a host asks for one any more and no test performs one:launch_authorityreads the rows that refuse to start it. The issue says so.No outbound rows are added. The owner ruled that rows judged from the stick alone, the T14 reaching its router and the internet, are built on ToyOS's own network stack ("no smoltcp.");
issues/toyos-has-its-own-network-stack.mdnow owns them in one line.The record
809c33c0crestores everything named above.issues/the-host-cannot-reach-the-t14-while-it-runs-toyos.mdsays so, and carries:lan_talkrestored and green.Also closed: the cable refusal that hid the stick-only row,
lan_talkunread since #763 (folded),lan_talk_host_closes' fixed window (29b4c651adeleted that test) and the unattributedswap_refused_device_failsred (test and client both gone). Every issue and track that cited a deleted row, boot, file or function is corrected; the ones that cited the ssh client, the swap or the served log as built now say it was built, is deleted, and where it comes back.The review of round 1, finding by finding
--ci hostand no guest suite at the head. Not closed by this branch's own runs: CI'shost,toolchain / buildandguest / suiteon the pushed head are what close it. What was run locally is below.SWAPframes, the threetoyos_logstreamconstants and the build gate./system/etc/ssh_authorized_keyshas no writer. The reader is deleted.issues/toyos-has-its-own-network-stack.mdowns them.metalcasesentence below is corrected.toyos-swapdoes not link into sshserver. Right: it links intosupervisorandswap. The sentence is gone from this body, and the root manifest's comment that said the same is corrected.Gates, at
25766b613The head is one commit past it, which changes
issues/the-host-cannot-reach-the-t14-while-it-runs-toyos.mdand nothing a build reads.Run by the orchestrator from the branch's request (
orch/builds/lanrows-r3.log), each by its own exit code:cargo test --test toyos-build -- --metal --liston809c33c0ccargo metadata --locked --format-version 1cargo test --test toyos-checks(36 tests)cargo test --locked --lib -- metal build:: cicache:: ci::(running 127 tests: 125 passed, 2 ignored)cargo test --locked -p toyos-swap(5 tests)cargo test --locked -p toyos-logstream(19 tests)cargo test --locked --manifest-path userland/logkeeper/Cargo.toml(10 tests)cargo test --locked --manifest-path userland/sshserver/Cargo.toml(29 tests)cargo run -- --build-onlycargo test --test toyos-build -- machine_shutdown console_image_boots netstack_socket_churn(4 passed, 4 total)cargo test --test toyos-build -- --metal --liston the branchAs the harness prints them:
The guest filters, and why:
machine_shutdownandmachine_shutdown_short_stopboot through the supervisor's stop, where logkeeper answers its flush on the connection that lost the swap frames;console_image_bootsboots the console, the one reader of the log on the machine, through logkeeper'slogport;netstack_socket_churnboots netstack beside a logkeeper that no longer asks for it. No guest boots sshserver: onlytests/metalcasestarts it.The T14, at
25766b613(orch/builds/t14-lanrows.log), run by the orchestrator:testcases(image sha25683c90d38d01f5c5d588ab54ef213de79a0132ea9d3f02f63b167c17885f8a8a6) rc 0 andtestcases-watchdog(7b6d51e4f9fa2bf0275d232c900c2f60fe66de0a3488bc9cbc9fa3361e14d7ce) rc 0; the judge exit 0, 21 passed and 0 failed over 2 boots. The log reached the stick (kernel.log16,960,405 bytes) and the supervisor stopped the machine.boot:metalcaseon the T14, at25766b613, booted by the orchestrator to read sshserver's key-file change on metal (his two comments on this pull request):toyos-metalexit 0, and it does not show the change. sshserver saysstarting..., thenno network on this machine, exiting, withcode=0, so it leaves before it reads any key file. The boot is not judged. No test at any tier reaches the changed reader: sshserver's 29 host tests callauthorizes(text, key)and none callsis_authorized,authorized_key_countorauthorized_keys(), and no guest starts the daemon. It is carried by the diff alone, and the issue says so.Not run here:
cargo run -- --ci hostand the whole guest suite; CI'shost,toolchain / buildandguest / suiteon the pushed head are what close the review's open blocker.For the reviewer to weigh
netstackrow for logkeeper ran is different, and the T14 boot above read the log path and the stop.CLAUDE.mddeletes a red test, with the issue recording the commit that restores them.userland/,toyos-logstream/,toyos-swap/) +66 −412;issues/+209 −451.🤖 Generated with Claude Code
https://claude.ai/code/session_01RvnWQFcMuGqTHYhvSnTe8A