Bound the update check's network calls with timeouts - #748
Merged
Conversation
checkUpdate() runs synchronously on the command handler thread inside the 30s command wakelock, twice a day (house-holding, sideloaded installs). The HttpsURLConnection had no connect/read timeouts, so a hung network could stall the command queue for the OS default timeout and hold a wakelock meanwhile. Give it 10s bounds on both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkUpdate()runs synchronously on the command handler thread inside the 30s command wakelock, twice a day (house-holding, sideloaded installs). ItsHttpsURLConnectionhad no connect/read timeouts, so a hung network could stall the command queue for the OS default TCP timeout and hold a wakelock meanwhile.Adds
UPDATE_CHECK_TIMEOUT_MS = 10_000applied to both connect and read. Verified with./gradlew :app:compileGithubDebugJavaWithJavac.