Skip to content

Count only the cost warning in the coordinate_patch_hooks warn-once test #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlarson4 merged 2 commits into from
Oct 19, 2026
Merged

Count only the cost warning in the coordinate_patch_hooks warn-once test #1910

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29c5fc7
Count only the cost warning in coordinate_patch_hooks warn-once test
YHC66 Oct 16, 2026
b3b8938
Shorten warn-once test comment
YHC66 Oct 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/unit/tools/test_jacobian_lens_coordinate_patch_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ def test_coordinate_patch_hooks_warns_once_naming_layer_and_position_counts(
)
with pytest.warns(UserWarning, match=r"2 layer\(s\) x 2 position\(s\)") as record:
lens.coordinate_patch_hooks(toy_model, 3, 5, layers=[0, 1], positions=[0, 1])
assert len(record) == 1
# Ensure test only fails due to the warning we are testing
cost_warnings = [w for w in record if "coordinate-patch hooks" in str(w.message)]
assert len(cost_warnings) == 1


def test_coordinate_patch_hooks_rejects_unfitted_layer(toy_model: _ToyBridge) -> None:
Expand Down
Loading