Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: a11y testing setup #3177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: a11y testing setup #3177
Changes from all commits
35b14f2a9740761fd7af89dee776177e7551de7a1675e158aa6bafae66f1a48c92db4b463e2377cf0798137f4d48fcb3552c218d8f331a87e9ff65d2a5856fFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Fix the version comment on the
actions/upload-artifactpins.zizmor reports that the
# v7comment does not match the pinned commit. Thev7tag points to a different commit (cf430e030ddb). The pinned hash most likely belongs to a patch release such asv7.0.1. This is the same form as theactions/checkoutpin (# v7.0.1).Replace the comment with the exact tag that resolves to the pinned hash. This clears both zizmor warnings.
Proposed fix (confirm the tag first)
Also applies to: 97-97
🧰 Tools
🪛 GitHub Check: zizmor
[warning] 49-49:
action's hash pin has mismatched or missing version comment: tag points to commit cf430e030ddb
🤖 Prompt for AI Agents
Source: Linters/SAST tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make sure this .md's are not merged, because afaik they're 1-off studies for this workstream. Anything in the repo should be long-lived
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, marked in the description as temporary. Just have to remember to remove them later, but still useful atm mainly so you can point agents to them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Do not claim that axe-core validates text-spacing and resize overrides.
Axe-core checks static accessibility rules. It does not execute WCAG 1.4.4 or 1.4.12 CSS overrides, or prove that content remains usable after those overrides. Describe axe-core as partial static coverage and keep a direct browser check for the resulting layout.
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Do not treat screen-reader navigation as implicit axe coverage.
Axe-core does not validate VoiceOver or NVDA rotor order, virtual-cursor movement, or spoken output. Require dedicated GuidePup or manual coverage for these behaviors, or mark them explicitly as out of scope.
🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.