Repository navigation
feat: Tables a11y (BLO-1230) (BLO-1231) - #3215
Open
matthewlipski wants to merge 2 commits into
Open
matthewlipski wants to merge 2 commits into
matthewlipski wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
matthewlipski
changed the title
matthewlipski
changed the title
matthewlipski
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds some additional HTML attributes to tables:
idscope(determines whether header is for a row or column)headers(determines which headers the cell is under)They are not required by WCAG guidelines and so are not caught in axe scans, but make the relationships between cells and headers more explicit, especially when they span multiple rows/columns.
This is implemented using decorations. Serializing to HTML has additional logic to apply the attributes as decorations can't be applied.
Closes #2825
Closes #2826
Rationale
This is an a11y improvement.
Changes
TableAccessibilityPluginto apply cell & header decorationsImpact
N/A
Testing
Updates table format conversion snapshots. No changes to a11y tests as axe scans do not check this.
Screenshots/Video
N/A
Checklist
Additional Notes
N/A