Skip to content

Fixed action toolbar in comments not being keyboard accessible - #3221

Open
matthewlipski wants to merge 2 commits into
a11y-testingfrom
comment-actions-a11y
Open

matthewlipski wants to merge 2 commits into
a11y-testingfrom
comment-actions-a11y

Conversation

@matthewlipski

Copy link
Copy Markdown
Collaborator

Summary

This PR fixes an issue where the action toolbar in comments is inaccessible with the keyboard. This is because the DOM element itself mounts/unmounts on show/hide. This PR changes it to just hide using opacity, so that it can still be exposed by focusing it with the keyboard.

Rationale

See above.

Changes

See above.

Impact

N/A

Testing

Added a11y tests.

Screenshots/Video

N/A

Checklist

  • Code follows the project's coding standards.
  • Unit tests covering the new feature have been added.
  • All existing tests pass.
  • The documentation has been updated to reflect the new feature

Additional Notes

N/A

@vercel

vercel Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
blocknote Ready Ready Preview Oct 20, 2026 6:11pm UTC
blocknote-website Ready Ready Preview Oct 20, 2026 6:11pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b3a65329-b76d-42d3-ac80-134cea0e8ab0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 20, 2026

Copy link
Copy Markdown

Open in StackBlitz

@blocknote/ariakit

npm i https://pkg.pr.new/@blocknote/ariakit@3221

@blocknote/code-block

npm i https://pkg.pr.new/@blocknote/code-block@3221

@blocknote/core

npm i https://pkg.pr.new/@blocknote/core@3221

@blocknote/diagram-block

npm i https://pkg.pr.new/@blocknote/diagram-block@3221

@blocknote/mantine

npm i https://pkg.pr.new/@blocknote/mantine@3221

@blocknote/math-block

npm i https://pkg.pr.new/@blocknote/math-block@3221

@blocknote/react

npm i https://pkg.pr.new/@blocknote/react@3221

@blocknote/server-util

npm i https://pkg.pr.new/@blocknote/server-util@3221

@blocknote/shadcn

npm i https://pkg.pr.new/@blocknote/shadcn@3221

@blocknote/xl-ai

npm i https://pkg.pr.new/@blocknote/xl-ai@3221

@blocknote/xl-docx-exporter

npm i https://pkg.pr.new/@blocknote/xl-docx-exporter@3221

@blocknote/xl-email-exporter

npm i https://pkg.pr.new/@blocknote/xl-email-exporter@3221

@blocknote/xl-multi-column

npm i https://pkg.pr.new/@blocknote/xl-multi-column@3221

@blocknote/xl-odt-exporter

npm i https://pkg.pr.new/@blocknote/xl-odt-exporter@3221

@blocknote/xl-pdf-exporter

npm i https://pkg.pr.new/@blocknote/xl-pdf-exporter@3221

@blocknote/xl-typst-exporter

npm i https://pkg.pr.new/@blocknote/xl-typst-exporter@3221

commit: 63a23d1

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://TypeCellOS.github.io/BlockNote/pr-preview/pr-3221/

Built to branch gh-pages at 2026-10-20 18:22 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

This branch was successfully deployed

2 active deployments
Preview – blocknote-website — ad65989c Deployed Oct 20, 2026 by vercel[bot]
Preview – blocknote — ad65989c Deployed Oct 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant