Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Linked Issues check |  |
Issue #3079 requires labels to remain visible at the editor right and top edges and inside tables. The supported-browser rules use position: fixed, CSS anchor positioning, and data-placement to pl… |
Provide an equivalent non-anchor fallback that keeps labels inside the editor at the right and top edges and inside tables, or document and enforce a browser-support requirement that is part of the issue scope. |
-
Check name Status Explanation Title check The title clearly summarizes the primary change: keeping collaboration cursor labels visible in tables and at screen edges. Out of Scope Changes check The changes remain connected to collaborative cursor labels. The showCursorLabels: "always"behavior, labels during remote typing,remoteEditors, lifecycle listener cleanup, and browser tests supp…Docstring Coverage Docstring coverage is 90.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 20 functions across 5 files. (1 skipped: 1 … Description check The description is detailed and covers the feature, rationale, implementation changes, impacts, known limitations, and testing. It does not use the template headings and omits the checklist and screen… Full details: Out of Scope Changes check
-
Explanation
The changes remain connected to collaborative cursor labels. The
showCursorLabels: "always"behavior, labels during remote typing,remoteEditors, lifecycle listener cleanup, and browser tests support label visibility and correctness. No unrelated change is established by the supplied diff and file evidence.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 90.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 20 functions across 5 files. (1 skipped: 1 unsupported.)
Full details: Description check
-
Explanation
The description is detailed and covers the feature, rationale, implementation changes, impacts, known limitations, and testing. It does not use the template headings and omits the checklist and screenshots section, but the substantive information is mostly complete and directly relevant.
-
Full details: Linked Issues check
-
Explanation
Issue
#3079requires labels to remain visible at the editor right and top edges and inside tables. The supported-browser rules useposition: fixed, CSS anchor positioning, anddata-placementto place labels left or below, andfloatCursorLabelapplies the anchor. The CSS also usesposition-visibility: anchors-visible. However, the implementation places these rules inside@supports (position-anchor: --a)and explicitly retains the clipping inline behavior in browsers without anchor positioning. Issue#3079does not exclude those browsers, so the requirement is not met for that browser class.Resolution
Provide an equivalent non-anchor fallback that keeps labels inside the editor at the right and top edges and inside tables, or document and enforce a browser-support requirement that is part of the issue scope.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit watched the cursor glide,
Then nudged its label to the side.
Up top, it hopped below the line,
When friends typed on, it stayed in time.
The rabbit thumped, “That label’s fine!”
Comment @coderabbitai help to get the list of available commands.
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/diagram-block
@blocknote/mantine
@blocknote/math-block
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
@blocknote/xl-typst-exporter
commit: |
|
This branch was successfully deployed
1 participant
Closes #3079. This is an alternative to #3095.
Problem
The label of a remote cursor was cut off:
Solution
The label is
position: fixed, so a scroll container does not clip it. CSS anchor positioning attaches the label to its caret, so the label follows the caret when the page scrolls or the text moves. The editor does not need code to position the label.When the label opens,
showCursorLabelpicks its side:CSS uses this side (
data-placement) for the position, for the corner from which the label grows, and for its square corner at the caret. The browser does not flip the label (position-try-fallbacks): it keeps a flipped side after the caret moves away from the edge, and CSS cannot tell which side the browser picked.The closed label is the marker at the top of the caret, as before. It opens and closes with an animation, as before.
Browsers without anchor positioning show the label as before (
@supports). The table and the edges of the screen can still clip it in these browsers.Other changes
showCursorLabels: "always"did not show the labels. Now it shows them.Compared with #3095
#3095 also uses CSS anchor positioning, but it moves the labels into the portal element. This PR keeps each label in its cursor. Thus, it does not need to sync labels with the awareness state, and it does not change the structure of the two cursor plugins. Also, it does not use
@container anchored, which only Chromium supports.Known limitations
showCursorLabels: "always".Tests
cursorLabel.browser.test.ts): a label in a table, at the top and at the right edge of the screen, after the cursor moves away from the right edge, while a collaborator types, and withshowCursorLabels: "always".YCursorPlugin.browser.test.ts): a label after a cursor move, while a collaborator types, withshowCursorLabels: "always", and the removal of the listeners.main.