Repository navigation
馃悰(frontend) adapt to the BlockNote 0.56 editor and exporter APIs - #13
Merged
Merged
Conversation
The frontend build fails with the BlockNote preview packages at
83153fda2e. In BlockNote 0.56, blockTypeSelectItems takes the editor,
a block's render function is optional, and an exporter block mapping can
be a function or { withChildren }.
Signed-off-by: yousefed <yousefdardiry@gmail.com>
A new BlockNote version can change its API. The deploy then fails in the frontend build, so check the types before the pull request. Signed-off-by: yousefed <yousefdardiry@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the frontend build. The dev instance deploy of #12 failed in the type check. The BlockNote preview packages at
83153fda2einclude BlockNote 0.56, which changes some APIs (TypeCellOS/BlockNote#3059).Changes
BlockNoteToolbar.tsx:blockTypeSelectItemstakes the editor, not the dictionary.CodeBlock.tsx: a block'srenderfunction is optional now. The code block wrapper throws if BlockNote's code block has none.mappingDocx.tsx: an exporter block mapping can be a function or{ withChildren }. The table mapping calls the default mapping in both cases. A table has no child blocks.imagePDF.tsx: the mapping has the plain function type, so the tests can call it directly. Most of the diff is indentation from prettier.Checks
tsc --noEmitinapps/impress: 0 errors (28 before).eslinton the changed files: no errors.vitestfordoc-exportandcustom-blocks: 90 tests pass.