fix(Toolbox): don't treat feed section templates as scripts#34
Merged
Conversation
Install discovery iterated a feed section's keys directly, so the format's section-scoped template keys (fileBaseUrls, localFileBasePaths) were built into records whose channel read then raised. Walk the feed's packages instead, which already skips them. getChannels returns an empty list for a package without channels, so one malformed entry can't take down a whole feed scan.
Contributor
Test results — macos-latest ✅1062 · ubuntu-latest ✅1062 · windows-latest ✅1059Summary
🎉 No failed tests in this run. Github Test Reporter by CTRF 💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Install Script macro dies while scanning feeds:
Install discovery iterated a feed section's keys directly, so the format's section-scoped template keys (
fileBaseUrls,localFileBasePaths) were handed togetScript, which builds a record from any table it gets. Reading that record's channels then raised. It affects any feed that sets URL templates per section — DependencyControl's own among them, so the macro is broken for everyone on 0.8.0.Discovery now walks the feed's packages, which already skips the non-package keys, and
getChannelsreturns an empty list for a package that declares none, so a single malformed entry can't take down a whole scan.Regression tests for both.
walkPackageshad none of its own despite being the canonical package filter.🤖 Generated with Claude Code