Skip to content

fix(evalboard): list date-named runs flagged adhoc in the Ad-hoc section #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bai-uipath merged 1 commit into from
Sep 25, 2026
+11 −8
Merged

fix(evalboard): list date-named runs flagged adhoc in the Ad-hoc section #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions evalboard/lib/overview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1310,7 +1310,8 @@ const ADHOC_LOAD_SLACK = 10;

// The Ad-hoc runs section (front page, below the daily listing). "Ad-hoc" here
// means "not a daily-pipeline run" — i.e. the id isn't date-shaped, which is
// exactly the set listRunIdsInWindow excludes from the chart and main table.
// exactly the set listRunIdsInWindow excludes from the chart and main table,
// plus date-named runs from the last 30 days that meta.json flags adhoc.
//
// Only the newest `limit + ADHOC_LOAD_SLACK` candidates are loaded, ordered by
// the date in the id; loading all 165 to show ten rows cost ~294 MB per cold
Expand All @@ -1336,13 +1337,15 @@ export async function getAdhocRunListing(
const budget = limit == null ? dated.length : limit + ADHOC_LOAD_SLACK;
const loadedAll = budget >= dated.length;
const toLoad = [...undated, ...dated.slice(0, budget).map((d) => d.id)];
const perRun = await mapWithConcurrency(
toLoad,
FETCH_CONCURRENCY,
cachedLoadPerRunFor(source),
);
const listing = buildAdhocRows(perRun, limit);
const [perRun, recentDaily] = await Promise.all([
mapWithConcurrency(toLoad, FETCH_CONCURRENCY, cachedLoadPerRunFor(source)),
loadWindowData("30d", source),
]);
const flaggedDaily = recentDaily.filter((r) => r.adhoc);
const listing = buildAdhocRows([...perRun, ...flaggedDaily], limit);
// `total` drives "Show more", so a truncated load must report the candidate
// count or the section caps itself at the first page.
return loadedAll ? listing : { ...listing, total: ids.length };
return loadedAll
? listing
: { ...listing, total: ids.length + flaggedDaily.length };
}
Loading