Skip to content

fix(sso): clear broker session on customer logout#1335

Merged
superdav42 merged 2 commits into
mainfrom
fix/sso-background-logout
Jun 3, 2026
Merged

fix(sso): clear broker session on customer logout#1335
superdav42 merged 2 commits into
mainfrom
fix/sso-background-logout

Conversation

@superdav42

Copy link
Copy Markdown
Collaborator

Summary

  • Clear the SSO broker session when a customer logs out.
  • Add regression coverage for broker-session cleanup behavior.

Changed files

  • inc/sso/class-sso.php
  • tests/WP_Ultimo/SSO/SSO_Test.php

Verification

  • bash bin/check-env.sh && vendor/bin/phpunit --filter SSO_Test

@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@superdav42, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 21 minutes and 53 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e06691a7-7655-4ab7-9511-83fee156b622

📥 Commits

Reviewing files that changed from the base of the PR and between e5945fa and 4244e1b.

📒 Files selected for processing (2)
  • inc/sso/class-sso.php
  • tests/WP_Ultimo/SSO/SSO_Test.php
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sso-background-logout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@superdav42 superdav42 added the origin:interactive Created by interactive user session label Jun 2, 2026
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

@superdav42

Copy link
Copy Markdown
Collaborator Author

MERGE_SUMMARY

Summary:

  • Rechecked PR fix(sso): clear broker session on customer logout #1335 terminal checks for fix/sso-background-logout.
  • No current terminal failed checks were present; all latest required jobs were passing except WP Performance Metrics, which remains pending and was not treated as a failure.
  • No code changes were made and no empty/no-op commit was pushed.

Verification:

  • WP_TESTS_DIR=/tmp/wordpress-tests-lib vendor/bin/phpunit --filter SSO_Test — passed (81 tests, 132 assertions).
  • gh pr checks 1335 --repo Ultimate-Multisite/ultimate-multisite --watch=false — no terminal failed checks.

@superdav42 superdav42 merged commit 0d8b945 into main Jun 3, 2026
9 of 10 checks passed
@superdav42 superdav42 deleted the fix/sso-background-logout branch June 3, 2026 11:18
@superdav42 superdav42 added the review-feedback-scanned Merged PR already scanned for quality feedback label Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

origin:interactive Created by interactive user session review-feedback-scanned Merged PR already scanned for quality feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant