FIX: [UUM-145509] Simulator Plugin disabling input devices always. - #2457
Open
diverges wants to merge 5 commits into
Open
FIX: [UUM-145509] Simulator Plugin disabling input devices always.#2457diverges wants to merge 5 commits into
diverges wants to merge 5 commits into
Conversation
|
|
diverges
force-pushed
the
platform/workflows/fix-input-manager-device-simulator-plugin
branch
from
July 22, 2026 16:53
b3043c8 to
96cd571
Compare
Fix an issue where the Simulator Window would disable all input devices while open even though the window was not focused. This caused "Game View" to not properly receive input events. - Added a UI foldout with helpbox explaining this behavior. - Used created UIElement to capture the panel `InputSystemPlugin` connects to. - Enable/Disable devices based on SimulatorWindow focus state.
diverges
force-pushed
the
platform/workflows/fix-input-manager-device-simulator-plugin
branch
from
July 22, 2026 16:54
96cd571 to
c40f0ce
Compare
diverges
changed the title
diverges
marked this pull request as ready for review
July 27, 2026 22:39
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Harness Review
The focus-based change is close, but there is still a play-mode transition hole in the new state machine, and the accompanying test coverage does not build as checked in.
Reviewed commit 0047e168
🤖 Helpful? 👍/👎
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #2457 +/- ##
===========================================
+ Coverage 78.95% 78.96% +0.01%
===========================================
Files 767 767
Lines 140780 140855 +75
===========================================
+ Hits 111153 111230 +77
+ Misses 29627 29625 -2 Flags with carried forward coverage won't be shown. Click here to find out more.
|
Pauliusd01
self-requested a review
July 29, 2026 06:10
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
Test Plan
Summary of Changes & Risk AssessmentSummary of ChangesThis PR fixes issue UUM-145509 where the Device Simulator plugin would globally disable native Key changes include:
Risk Assessment
Test ScenariosFunctional Testing
Regression Testing
Edge Cases
💡 This test plan updates automatically when 🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr |
…ce-simulator-plugin
Pauliusd01
reviewed
Jul 29, 2026
| - Fixed `OnMouseUpAsButton` and `OnMouseUp` being dropped in Play mode when the Game view's focus changes between a press and its release on Unity 6000.5.0a8 and newer. The legacy `SendMouseEvents` pipeline is no longer driven from `InputUpdateType.Editor` updates, which read the editor state buffer (position (0,0), not pressed) and produced a spurious mouse release that cleared the press target. | ||
| - Fixed Input Debugger window's incorrect name. It is now called 'Input Debugger' instead of 'Input Debug' [UUM-137124](https://jira.unity3d.com/browse/UUM-137124). | ||
| - Fixed `PoseControl.isTracked` always returning false when read through non-optimized code paths (e.g. Input Debugger) due to `sizeInBits = 8` causing the value to be normalized as `1/255` instead of `1.0`. | ||
| - Fixed the Device Simulator plugin keeping the real mouse and pen disabled while working in other Editor windows. Conflicting native `Mouse`/`Pen` devices are now only disabled while the Simulator window is focused and re-enabled as soon as focus moves elsewhere [UUM-145509](https://jira.unity3d.com/browse/UUM-145509). |
Collaborator
There was a problem hiding this comment.
Make sure this is under the "unreleased" version, we already released 1.20.0
Pauliusd01
approved these changes
Jul 29, 2026
Pauliusd01
left a comment
Pauliusd01
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, checked the /test_plan command tests, looked over our sample scenes with simulator window open, checked whether simulate touch setting still works
VeraMommersteeg
approved these changes
Jul 29, 2026
VeraMommersteeg
left a comment
VeraMommersteeg
left a comment
Collaborator
There was a problem hiding this comment.
docs failing is on develop as well, the other functional tests are passsing. Paulius says it still behaves the same so lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix an issue where the Simulator Window would disable all input devices while open even though the window was not focused. This caused "Game View" to not properly receive input events.
InputSystemPluginconnects to.Screen.Recording.2026-07-22.094016.mp4
Testing status & QA
Manual Testing.
Added automated tests for:
Overall Product Risks
Comments to reviewers
Device simulator related fixes.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.