Skip to content

FIX: [Port] [ISX-1735] Fix misaligned labels in the Input Actions editor properties pane - #2487

Merged
josepmariapujol-unity merged 2 commits into
developfrom
input/isx-1735/actions
Sep 28, 2026
Merged

josepmariapujol-unity merged 2 commits into
developfrom
input/isx-1735/actions

Conversation

@josepmariapujol-unity

@josepmariapujol-unity josepmariapujol-unity commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Backport of: https://github.cds.internal.unity3d.com/unity/unity/pull/126186

Fix misaligned labels in the Input Actions editor properties pane.

In the Action Properties pane, the Action Type, Control Type and Priority labels were pinned to 90px while the Initial State Check toggle used the 120px UI Toolkit default, so its checkbox sat 30px right of the dropdowns.

In the Binding Properties pane, the Path row is drawn with IMGUI and sized its label to the text, while the Composite Part dropdown used the 120px UI Toolkit default, so the two inputs started about 75px apart.

image

Testing status & QA

Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity: 0
  • Halo Effect: 0

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@josepmariapujol-unity josepmariapujol-unity changed the title [ISX-1735] Fix misaligned labels in the Input Actions editor properties pane FIX: [Port] [ISX-1735] Fix misaligned labels in the Input Actions editor properties pane Sep 28, 2026

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Ship it

The change aligns labels across the action and binding properties panes. I checked stylesheet reachability, pane sizing, composite-part layout, and other control path editor callers; I found no actionable issue.

Reviewed commit b2cef08

🤖 Helpful? 👍/👎

@josepmariapujol-unity josepmariapujol-unity self-assigned this Sep 28, 2026

@Pauliusd01 Pauliusd01 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low risk, only checked that the code changes match trunk PR

@josepmariapujol-unity

josepmariapujol-unity commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator Author

I will manually check that it works, before landing

@josepmariapujol-unity

Copy link
Copy Markdown
Collaborator Author
Screenshot 2026-09-28 at 10 50 07

@codecov-github-com

codecov-github-com Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...tem/Editor/ControlPicker/InputControlPathEditor.cs 0.00% 2 Missing ⚠️
...Editor/Views/CompositePartBindingPropertiesView.cs 0.00% 2 Missing ⚠️
...tor/UITKAssetEditor/Views/BindingPropertiesView.cs 0.00% 1 Missing ⚠️
@@           Coverage Diff            @@
##           develop    #2487   +/-   ##
========================================
  Coverage    78.95%   78.96%           
========================================
  Files          767      767           
  Lines       140914   140988   +74     
========================================
+ Hits        111262   111329   +67     
- Misses       29652    29659    +7     
Flag Coverage Δ
inputsystem_MacOS_6000.0 5.30% <0.00%> (-0.01%) ⬇️
inputsystem_MacOS_6000.0_project 77.50% <50.00%> (+<0.01%) ⬆️
inputsystem_MacOS_6000.3 5.30% <0.00%> (-0.01%) ⬇️
inputsystem_MacOS_6000.3_project 77.49% <50.00%> (+<0.01%) ⬆️
inputsystem_MacOS_6000.6 5.29% <0.00%> (-0.01%) ⬇️
inputsystem_MacOS_6000.6_project 77.55% <50.00%> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.0 5.30% <0.00%> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.0_project 77.41% <50.00%> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.3 5.30% <0.00%> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.3_project 77.40% <50.00%> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.6 5.29% <0.00%> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.6_project 77.46% <50.00%> (+0.01%) ⬆️
inputsystem_Windows_6000.0_project 77.63% <50.00%> (+0.01%) ⬆️
inputsystem_Windows_6000.3_project 77.62% <50.00%> (+<0.01%) ⬆️
inputsystem_Windows_6000.6_project 77.68% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tor/UITKAssetEditor/InputActionsEditorConstants.cs 100.00% <100.00%> (ø)
...itor/UITKAssetEditor/Views/ActionPropertiesView.cs 61.11% <100.00%> (-2.44%) ⬇️
...tor/UITKAssetEditor/Views/BindingPropertiesView.cs 0.00% <0.00%> (ø)
...tem/Editor/ControlPicker/InputControlPathEditor.cs 0.00% <0.00%> (ø)
...Editor/Views/CompositePartBindingPropertiesView.cs 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

ℹ️ Need help interpreting these results?

@josepmariapujol-unity
josepmariapujol-unity merged commit 2c451ed into develop Sep 28, 2026
58 of 71 checks passed
@josepmariapujol-unity
josepmariapujol-unity deleted the input/isx-1735/actions branch September 28, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants