Repository navigation
Conversation
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Harness Review
The change adds source locations to ILPP diagnostics and preserves originating members for serialization errors. I examined all changed call sites, symbol loading, source-location fallbacks, inherited-field handling, and RPC body rewriting.
Reviewed commit f7e2c9d
🤖 Helpful? 👍/👎
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop-3.x.x #4250 +/- ##
=================================================
- Coverage 76.73% 76.72% -0.02%
=================================================
Files 159 159
Lines 28101 28101
=================================================
- Hits 21564 21561 -3
- Misses 6537 6540 +3
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Currently most of our ILPP errors are emitted without a source location. This PR updates the logic to emit a source location on the ILPP diagnostics. This makes ILPP diagnostic messages clickable in the editor. When you click on the error you're taking to the project source code that emitted the error.
Jira ticket
n/a
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Up-port
n/a
Backports
This is a chore and so shouldn't be backported.