Skip to content

Add 10.13 to test matrix#517

Open
urfeex wants to merge 2 commits into
UniversalRobots:masterfrom
urfeex:test_10.13
Open

Add 10.13 to test matrix#517
urfeex wants to merge 2 commits into
UniversalRobots:masterfrom
urfeex:test_10.13

Conversation

@urfeex

@urfeex urfeex commented Jun 10, 2026

Copy link
Copy Markdown
Member

Run integration tests on 10.13, as well.


Note

Low Risk
Changes are limited to CI matrix expansion, test fixtures, and integration-test timing; no production library behavior is modified.

Overview
Adds URSim 10.13.0 coverage to CI by running the integration test job with ur15 and the PolyScope X program folder.

Supporting changes reduce flakes on newer simulators: program_interaction now polls commandGetLoadedProgram() for up to 1s after load instead of asserting immediately. The update_prog.urpx fixture renames the application to update_application.

Reviewed by Cursor Bugbot for commit 5cbb8a3. Bugbot is set up for automated code reviews on this repo. Configure here.

@urfeex urfeex requested a review from a team June 10, 2026 11:46
@urfeex urfeex added the CI label Jun 10, 2026
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.72%. Comparing base (ca25b13) to head (5cbb8a3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
- Coverage   78.85%   78.72%   -0.13%     
==========================================
  Files         116      116              
  Lines        6612     6610       -2     
  Branches     2920     2920              
==========================================
- Hits         5214     5204      -10     
- Misses       1031     1041      +10     
+ Partials      367      365       -2     
Flag Coverage Δ
check_version_ur10-3.15.8 11.43% <ø> (-1.48%) ⬇️
check_version_ur10e-10.11.0 11.43% <ø> (-0.05%) ⬇️
check_version_ur10e-5.15.2 11.38% <ø> (-0.42%) ⬇️
check_version_ur12e-10.12.1 11.38% <ø> (-0.05%) ⬇️
check_version_ur12e-5.25.1 11.38% <ø> (-0.42%) ⬇️
check_version_ur15-10.12.1 11.38% <ø> (ø)
check_version_ur15-5.25.1 11.38% <ø> (-0.05%) ⬇️
check_version_ur16e-10.12.1 11.38% <ø> (-0.05%) ⬇️
check_version_ur16e-5.25.1 11.38% <ø> (-0.20%) ⬇️
check_version_ur18-10.12.1 11.38% <ø> (-0.05%) ⬇️
check_version_ur18-5.25.1 11.38% <ø> (-0.24%) ⬇️
check_version_ur20-10.12.1 11.43% <ø> (ø)
check_version_ur20-5.25.1 11.38% <ø> (ø)
check_version_ur3-3.14.3 10.81% <ø> (-1.04%) ⬇️
check_version_ur30-10.12.1 11.38% <ø> (-0.10%) ⬇️
check_version_ur30-5.25.1 11.38% <ø> (-0.24%) ⬇️
check_version_ur3e-10.11.0 11.38% <ø> (ø)
check_version_ur3e-5.9.4 11.38% <ø> (ø)
check_version_ur5-3.15.8 11.43% <ø> (-0.79%) ⬇️
check_version_ur5e-10.11.0 11.38% <ø> (ø)
check_version_ur5e-5.12.8 11.43% <ø> (-0.05%) ⬇️
check_version_ur7e-10.11.0 11.38% <ø> (ø)
check_version_ur7e-5.22.2 11.43% <ø> (+0.04%) ⬆️
check_version_ur8long-10.12.1 11.38% <ø> (-0.05%) ⬇️
check_version_ur8long-5.25.1 11.38% <ø> (-0.20%) ⬇️
python_scripts 75.90% <ø> (ø)
start_ursim 83.63% <ø> (-1.57%) ⬇️
ur5-3.14.3 74.52% <ø> (-0.12%) ⬇️
ur5e-10.11.0 68.80% <ø> (-0.20%) ⬇️
ur5e-10.12.0 69.91% <ø> (-0.18%) ⬇️
ur5e-10.7.0 68.33% <ø> (-0.36%) ⬇️
ur5e-5.9.4 75.12% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@urrsk

urrsk commented Jun 12, 2026

Copy link
Copy Markdown
Member

@urfeex It seems the 10.13.0 is timing out in the CI!

@urfeex

urfeex commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

@urfeex It seems the 10.13.0 is timing out in the CI!

Ah, that's probably because of the UR15 robot model I chose there. The motion sequence contains linear pose targets that might not be applicable to a UR15. I checked with a UR5e locally. I'll check things again. There also seem to be a failing tests regarding the robot-api that we need to address.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit 5cbb8a3. Configure here.

Comment thread .github/workflows/ci.yml
PROGRAM_FOLDER: 'tests/resources/dockerursim/programs/polyscopex'
- ROBOT_MODEL: 'ur15'
URSIM_VERSION: '10.13.0'
PROGRAM_FOLDER: 'tests/resources/dockerursim/programs/polyscopex'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UR15 breaks full integration job

Medium Severity

The new 10.13.0 matrix entry uses ur15 while other PolyScope X rows in the same run_tests job use ur5e, yet it still runs the full ctest suite and run_examples.sh against the shared polyscopex program folder. That mismatch aligns with reported CI timeouts when example motion (e.g. linear poses) is not valid for UR15.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 5cbb8a3. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants