Send script blocking return refactor#520
Merged
urfeex merged 16 commits intoJun 16, 2026
Merged
Conversation
To avoid circular dependencies
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #520 +/- ##
==========================================
+ Coverage 78.87% 78.94% +0.07%
==========================================
Files 116 116
Lines 6612 6688 +76
Branches 2920 2953 +33
==========================================
+ Hits 5215 5280 +65
- Misses 1031 1045 +14
+ Partials 366 363 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
urfeex
approved these changes
Jun 15, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 96e6804. Configure here.
This way, every possible level has to be explicitly categorized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method now throws in any case where it would previously return false.
Note
High Risk
Breaking API change for all sendScriptBlocking callers; robot script execution error paths now throw instead of returning false, which can change control flow in integrators.
Overview
PrimaryClient::sendScriptBlockingis nowvoid: every formerfalseoutcome throws a typedUrException(e.g.TimeoutException,RobotModeException,SafetyModeException,RobotRuntimeException,RobotErrorCodeException,ReadOnlyInterfaceException,StreamNotConnectedException). Success is implied when the call returns normally.Failure handling in
sendScriptBlockingwas reworked to build aggregated error messages, treatCRITICAL_FAULTlike fault/violation during script execution, and map controller error 210 toReadOnlyInterfaceException. Runtime failures are thrown asRobotRuntimeExceptionwith script context instead of only logging.ReportLevel(plusreportLevelString) moved from the primary error-code message header intour/datatypes.h, withCRITICAL_FAULT/DEVL_CRITICAL_FAULTadded;PrimaryConsumerlogging now covers those levels explicitly.Docs,
examples/send_script.cpp, and tests were updated for the exception-based API.Reviewed by Cursor Bugbot for commit db63a4f. Bugbot is set up for automated code reviews on this repo. Configure here.