feat(etl-uvicorn): carry failure_category through invoke and precheck responses - #76
Closed
CyMule wants to merge 1 commit into
Closed
feat(etl-uvicorn): carry failure_category through invoke and precheck responses#76CyMule wants to merge 1 commit into
CyMule wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by #77. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
failure_categorytoInvokeResponseandInvokePrecheckResponse, populated from afailure_categoryattribute on the raised error (same pattern as the existingstatus_codepickup), and thread it through the/precheckroutefailure_categorycontract (DTPL-525) through the standardprecheck_func=wiring; today the response model silently drops the field, which forced the partitioner to strip and reinstall the SDK's precheck routes (Unstructured-IO/platform-plugins#1780)Follow-up after release: revert the partitioner to
precheck_func=wiring and delete its route-stripping inmain.py(DTPL-694).Testing
PYTHONPATH=. uv run pytest test/api/test_api.py— 43 passed, including new coverage for a failing precheck carryingfailure_categoryand a passing precheck leaving it nullruff formatcomplaint inapi_generator.pypredates this change)