Repository navigation
[k2] increase timeouts precision - #1714
Merged
Merged
Conversation
PetrShumilov
force-pushed
the
pshumilov/fix_curl_timeouts
branch
from
November 12, 2026 13:38
9bb3259 to
892073e
Compare
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
PetrShumilov
force-pushed
the
pshumilov/fix_curl_timeouts
branch
from
November 12, 2026 13:49
892073e to
2296582
Compare
Clamp timeouts in floating-point seconds before rounding up to milliseconds. Preserve the 300 ms default and the 1 ms to 24 hour bounds, and handle NaN and infinities before any conversion to an integral duration. Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
Extend the existing curl integration suite with a successful fractional budget, the default fallback for a tiny negative timeout, and exact-zero behavior. Keep the existing timeout failure case. Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
PetrShumilov
force-pushed
the
pshumilov/fix_curl_timeouts
branch
from
November 12, 2026 14:44
2296582 to
ba13824
Compare
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
PetrShumilov
force-pushed
the
pshumilov/fix_curl_timeouts
branch
from
November 12, 2026 15:35
ccf3bb3 to
cb69d3c
Compare
denisichh
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.