Skip to content

[k2] force conversion of specific curl_setopt arguments to vector - #1718

Merged
PetrShumilov merged 1 commit into
masterfrom
pshumilov/fix_strval_in_curlsetopt_attempt_2
Nov 18, 2026
Merged

PetrShumilov merged 1 commit into
masterfrom
pshumilov/fix_strval_in_curlsetopt_attempt_2

Conversation

@PetrShumilov

@PetrShumilov PetrShumilov commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Now such arguments will be interpreted identically:

  • curl_setopt($c, CURLOPT_HTTPHEADER, ["header" => 123, 1 => "bar"])
  • curl_setopt($c, CURLOPT_HTTPHEADER, ["123", "bar"])

Keys are ignored and values are converted with f$strval() in iteration order.

… options into vector

Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov PetrShumilov added this to the next milestone Nov 17, 2026
@PetrShumilov PetrShumilov self-assigned this Nov 17, 2026
@PetrShumilov PetrShumilov added small fix When it's not an huge enhancement runtime Feature related to runtime k2 Affects compiler or runtime in K2 mode labels Nov 17, 2026

@denisichh denisichh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PetrShumilov
PetrShumilov merged commit 6c03564 into master Nov 18, 2026
6 of 8 checks passed
@PetrShumilov
PetrShumilov deleted the pshumilov/fix_strval_in_curlsetopt_attempt_2 branch November 18, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

k2 Affects compiler or runtime in K2 mode runtime Feature related to runtime small fix When it's not an huge enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants