Skip to content

Delay-load dbghelp.dll in bindiff_similarity (Fix #1860) #8452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xusheng6 wants to merge 1 commit into
base: dev
Choose a base branch
from
+7 −0
Open

Delay-load dbghelp.dll in bindiff_similarity (Fix #1860) #8452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions plugins/bindiff_similarity/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,13 @@ target_link_libraries(${PROJECT_NAME}
bindiff_shared
)

if (WIN32 AND NOT DEMO)
# Abseil's symbolizer imports dbghelp.dll. A static import maps System32's copy at plugin init,
# which then wins name-based resolution and breaks the debugger's WinDbg dbgeng.
target_link_libraries(${PROJECT_NAME} PRIVATE delayimp.lib) # Helper for /DELAYLOAD
target_link_options(${PROJECT_NAME} PRIVATE /DELAYLOAD:dbghelp.dll)
endif ()

if (APPLE)
target_link_options(${PROJECT_NAME} PRIVATE
"LINKER:-exported_symbol,_CorePluginABIVersion"
Expand Down