Add SettleAppliedInline for applied patches - #850
Merged
Conversation
Introduce `DiffRunner.SettleAppliedInline(InlinePatch)` to retire inline queue entries after a patch is applied outside the test run (IDE/plugin/staged fallback). Unlike `SettleInline`, it does not stamp the caller’s framework, avoiding silent misses when queued entries were created by another target framework, and it uses patch metadata (including `MemberName`) to keep settling reliable when line numbers move. Docs and inline engine tests were updated to explain and lock in this behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
DiffRunner.SettleAppliedInline(InlinePatch)to retire inline queue entries after a patch is applied outside the test run (IDE/plugin/staged fallback). UnlikeSettleInline, it does not stamp the caller’s framework, avoiding silent misses when queued entries were created by another target framework, and it uses patch metadata (includingMemberName) to keep settling reliable when line numbers move. Docs and inline engine tests were updated to explain and lock in this behavior.