Inline append past local declaration - #853
Merged
Merged
Conversation
A member floor judged the recorded line stale whenever any declaration sat between the member's declaration and the hint, and IsDeclaration answers "is this identifier being declared rather than called", which a local satisfies: var hash = Hash(), and F#'s let hash = hash (), read as declarations exactly as a sibling test method does. That dropped the hint from the first try and from the outward walk both, so the call sitting exactly where the hint said was never looked at. Every test of the ordinary shape - a local, then a verify call on it - failed to accept, reporting "No Verify or Throws call at line N". Indentation is what tells the two apart, since nothing in front of the name does. A declaration indented past the member's own is inside its body - a local, a local function, a nested type - and none of those put the recorded line in another member. A sibling shares the member's indentation, so the comparison is inclusive and the stale-hint protection is unchanged. Fixtures that a raw string can carry are now written as one, normalized on the way in because a raw string takes the line endings of the file holding it. The rest stay hand-built: runs of three or more quotes, tabs, and the fixtures whose subject is line endings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.