Repository navigation
Take the heads' build and packaging from PlatformHeads - #954
Merged
Merged
Conversation
The viewer's native build was worked out here and copied into BuildMonitor, and fixes made here did not reach the copy: a Linux library that needed glibc 2.38, a raylib build whose window stayed blank, and libraries recorded as needed that a stock Ubuntu lacks were each fixed here and then found again there. PlatformHeads is the one copy, made from this one, and this takes its 0.1.0 in the three forms it comes in: - build-native.yml calls its reusable workflow in place of the jobs it had. - native/CMakeLists.txt fetches its CMake module, which pins raylib and Dear ImGui, switches off the raylib 6.0 options and links the library. What is left here is the viewer's own: its formats, its source file, and Threads and dl. - DiffEngine.csproj lists a PlatformHead for each RID and the package's targets publish and bundle them, in place of PublishViewerHeads and AddViewerToPackage, staged in obj\viewer as before. DiffEngineTray asks for the Windows heads by PlatformHeadsPublish. The Mac and Linux heads set PlatformHeadsNativeRuntimes in place of their own runtimes items. DE0001 is PH0001. native/build-linux.sh goes, since the workflow carries the script and PlatformHeads keeps it for running by hand. One thing that ships changes. The formats named are PNG, JPG, BMP and GIF, which is what the comment here always said, and the module leaves out every format not named. QOI and DDS were in the library only because raylib 6.0's CMake defaults every option to on, and the viewer hands raylib neither. Built in the container the linux-x64 library is 8 KB smaller for it, and with those two named it is byte for byte the one committed. The committed binaries are not changed here: build-native rebuilds them and opens the PR. A Release build makes all five packages with the entries Packaging.Tests has on record.
Co-authored-by: SimonCropp <122666+SimonCropp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The viewer's native build was worked out here and copied into BuildMonitor, and fixes made here did not reach the copy. PlatformHeads is the one copy, made from this one, and this takes its
0.1.0. BuildMonitor took it in SimonCropp/BuildMonitor#51.What changes
build-native.ymlcalls PlatformHeads' reusable workflow in place of the jobs it had.native/CMakeLists.txtfetches its CMake module, which pins raylib and Dear ImGui, switches off the raylib 6.0 options and links the library. What is left here is the viewer's own: its formats, its source file, andThreadsanddl.DiffEngine.csprojlists aPlatformHeadfor each RID, and the package's targets publish and bundle them in place ofPublishViewerHeadsandAddViewerToPackage, staged inobj\vieweras before.DiffEngineTray.csprojasks for the two Windows heads byPlatformHeadsPublish.PlatformHeadsNativeRuntimesin place of their ownruntimesitems.DE0001becomesPH0001.native/build-linux.shgoes: the workflow carries the script, and PlatformHeads keeps it for running by hand.Three pins name the one tag and move together: the workflow's
uses:, theGIT_TAGinnative/CMakeLists.txt, andPlatformHeadsinDirectory.Packages.props.One thing that ships changes
The formats named are PNG, JPG, BMP and GIF, which is what the comment here always said, and the module leaves out every format not named. QOI and DDS were in the Linux library only because raylib 6.0's CMake defaults every option to on, and the viewer hands raylib neither (
ImageExtensions). So the Linux libraries are rebuilt, 8 KB smaller, by the binaries PRbuild-nativeopens against this branch.Checked
GLIBC_2.27, records the same needed libraries, loads on glibc 2.28 and answersdeview_version()with 12.Packaging.Testspasses against the snapshots it already had, the tray's package included.The main test suites were not run locally. The names of the
Build nativechecks change, since the jobs are now inside a called workflow.