Repository navigation
feat(create): add --org-name to package and cli subcommands - #1789
Draft
marcossevilla wants to merge 3 commits into
Draft
marcossevilla wants to merge 3 commits into
marcossevilla wants to merge 3 commits into
Conversation
7 tasks
marcossevilla
force-pushed
the
feat/org-name-package-cli
branch
from
October 29, 2026 12:43
f6e42f9 to
c335a5c
Compare
The app_ui, dart_cli, dart_package and flutter_package bundles declare an org_name var (the LICENSE copyright holder) that the CLI never passed, so users could not set it and the template vars check failed. Extract docs_site's free-form --org-name option into a FreeFormOrgName mixin with a per-command defaultOrgName, and apply it to those four subcommands. Each default matches the current bundle default, so generated output is unchanged unless the flag is passed. The value resolves from the flag, then very_good.yaml create.org_name, then the default; note that a create.org_name in very_good.yaml now also applies to these commands' LICENSE.
marcossevilla
force-pushed
the
feat/org-name-package-cli
branch
from
October 29, 2026 12:50
c335a5c to
277180f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Part 3/3 of stack #1790. Makes the template vars check from #1788 green.
The
app_ui,dart_cli,dart_packageandflutter_packagebundles declareorg_name(theLICENSEcopyright holder) but the CLI never passed it.--org-name/--orgoption into aFreeFormOrgNamemixin with a per-commanddefaultOrgName(no reverse-domain validation, unlikeOrgName; combining both throws at construction).com.example.verygoodappforapp_ui_package,Very Good Venturesotherwise), so generated output is unchanged unless the flag is passed.--org-name>very_good.yamlcreate.org_name>defaultOrgName. docs_site usage and vars are unchanged.create.org_nameinvery_good.yaml(often a reverse-domain id likecom.very.good) now also applies to these commands, so it will appear as the copyright holder in their generatedLICENSE.Type of Change