Repository navigation
chore: run very_good_analysis with no rule overrides - #102
Merged
Merged
Conversation
ryzizub
marked this pull request as ready for review
October 21, 2026 12:20
marcossevilla
previously approved these changes
Oct 21, 2026
2 of 8 tasks
marcossevilla
force-pushed
the
chore/full-very-good-analysis
branch
from
October 28, 2026 11:54
f034d12 to
e144274
Compare
marcossevilla
force-pushed
the
chore/full-very-good-analysis
branch
3 times, most recently
from
October 28, 2026 12:28
2ffb6b6 to
965955f
Compare
Both packages disabled public_member_api_docs. Very Good CLI disables nothing
and excludes generated files in the analyzer section instead, so do the same
and document the members that were missing a comment.
The lint reads a Dart 3.13 primary constructor as an undocumented member, and
the class's own doc comment does not satisfy it. The only thing that does is
declaring the constructor in the body as `this;` under `/// {@macro name}`.
Very Good CLI puts its constructor doc in the same place; it just never needs
the bare declaration, because it has no primary constructors.
marcossevilla
force-pushed
the
chore/full-very-good-analysis
branch
from
October 28, 2026 12:30
965955f to
af342b0
Compare
marcossevilla
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stack 5 of 5 for #68. Base:
docs/completion-and-windows-support(#101).Both packages disabled
public_member_api_docs. Very Good CLI disables nothing and excludes generated files in theanalyzersection instead, so this does the same and documents the members that were missing a comment.The bulk of the diff is mechanical, and worth knowing before reading it: the lint reads a Dart 3.13 primary constructor as an undocumented member, and the class's own doc comment does not satisfy it. The only thing that does is declaring the constructor in the body as
this;under/// {@macro name}. Very Good CLI puts its constructor doc in exactly the same place — it just never needs the bare declaration, because it has no primary constructors. The cost is about two lines per public class, now and for every class added later.Type of Change
🤖 Generated with Claude Code