Repository navigation
fix: quieten the update check and say how to recover a newer manifest - #99
Merged
Merged
Conversation
marcossevilla
force-pushed
the
fix/update-check-and-manifest-guidance
branch
from
October 28, 2026 11:54
11a0102 to
dd8d757
Compare
The update check asked pub.dev about a package that is not published, so every command ended with "Failed to check for updates." Very Good CLI swallows the same failure; it is a best-effort check that should not be an error. ReportingManifestStore now tells the user to run `vgv_ai update` when the manifest was written by a newer version, which only doctor did. --only lists what each harness is, --force is coloured like every other flag, and the resolver's git output reaches --verbose. Also extracts commandHome, which three commands had inlined, and a shared TestRunner so the command tests stop declaring the same three mocks.
marcossevilla
force-pushed
the
fix/update-check-and-manifest-guidance
branch
from
October 28, 2026 11:55
dd8d757 to
226f4a9
Compare
Member
|
@vgvbot /address-review |
|
I've pushed changes to address the feedback. |
Co-authored-by: marcossevilla <marcossevilla@users.noreply.github.com>
marcossevilla
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stack 2 of 5 for #68. Base:
fix/clone-timeout(#98).The update check asked pub.dev about a package that is not published, so every command ended with
Failed to check for updates.Very Good CLI swallows the same failure; it is a best-effort check that should not be an error.ReportingManifestStorenow tells the user to runvgv_ai updatewhen the manifest was written by a newer version, which onlydoctordid.--onlylists what each harness is instead of bare enum names,--forceis coloured like every other flag, and the resolver's git output reaches--verbose.Also extracts
commandHome, which three commands had inlined, and adds a sharedTestRunnerso the command tests stop declaring the same three mocks.Type of Change
🤖 Generated with Claude Code