Skip to content

LOG-9314: Share a single state machine among instances of log stream groups#254

Open
jcantrill wants to merge 1 commit intoViaQ:v0.47.0-rhfrom
jcantrill:log9314
Open

LOG-9314: Share a single state machine among instances of log stream groups#254
jcantrill wants to merge 1 commit intoViaQ:v0.47.0-rhfrom
jcantrill:log9314

Conversation

@jcantrill
Copy link
Copy Markdown
Member

@jcantrill jcantrill commented Apr 14, 2026

This PR:

  • Modifies the detect_exceptions transform to create a single instance of the state machine to share among log streams

Impact :

  • Memory savings: Instead of N copies (one per container), there's now 1 shared copy
  • Scalability: Memory usage is now O(1) for the state machine instead of O(number of log streams)

ref: https://redhat.atlassian.net/browse/LOG-9314

@openshift-ci openshift-ci bot requested a review from syedriko April 14, 2026 21:24
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from vparfonov April 14, 2026 21:24
@jcantrill
Copy link
Copy Markdown
Member Author

cc @vparfonov

@jcantrill
Copy link
Copy Markdown
Member Author

/hold

};

// Create the state machine once and share it across all accumulators
let state_machine = Arc::new(exception_detector::get_state_machines(config.languages.clone()));
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo fmt

@vparfonov
Copy link
Copy Markdown

/test unit

@vparfonov
Copy link
Copy Markdown

/test clo-functional

@vparfonov
Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 15, 2026
@vparfonov vparfonov changed the title LOG-9314: Share a single state machine amoung instances of log stream… LOG-9314: Share a single state machine among instances of log stream groups Apr 15, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 15, 2026

@jcantrill: This pull request references LOG-9314 which is a valid jira issue.

Details

In response to this:

This PR:

  • Modifies the detect_exceptions transform to create a single instance of the state machine to share among log streams

Impact :

  • Memory savings: Instead of N copies (one per container), there's now 1 shared copy
  • Scalability: Memory usage is now O(1) for the state machine instead of O(number of log streams)

ref: https://redhat.atlassian.net/browse/LOG-9314

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 15, 2026

New changes are detected. LGTM label has been removed.

@vparfonov
Copy link
Copy Markdown

/test clo-functional

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 15, 2026

@jcantrill: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/cargo-fmt-check fe5e7ec link false /test cargo-fmt-check
ci/prow/unit fe5e7ec link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vparfonov
Copy link
Copy Markdown

/test clo-functional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants