Skip before_render when render? returns false by Copilot · Pull Request #2719 · ViewComponent/view_component

Copilot · 2026-10-09T16:21:37Z

before_render currently runs even when render? returns false, causing side effects for components that never render.

Lifecycle: Move before_render inside the render? guard.
Coverage: Add regressions for skipped hooks, callback order, and HTML-safe empty output.
Documentation: Clarify that render? runs first and cannot depend on state initialized by before_render.

Co-authored-by: joelhawksley <1940294+joelhawksley@users.noreply.github.com>

Initial plan

2a18062

Copilot AI assigned Copilot and joelhawksley Oct 9, 2026

Copilot started work on behalf of joelhawksley October 9, 2026 16:21 View session

Copilot AI linked an issue Oct 9, 2026 that may be closed by this pull request

before_render should respect render? #2718

Closed

Skip before_render when render? returns false

4c23033

Co-authored-by: joelhawksley <1940294+joelhawksley@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix before_render method to respect render?~~ Skip before_render when render? returns false Oct 9, 2026

Copilot finished work on behalf of joelhawksley October 9, 2026 16:27

Copilot AI requested a review from joelhawksley October 9, 2026 16:27

joelhawksley closed this Oct 9, 2026

joelhawksley deleted the copilot/before-render-respect-render-check branch October 9, 2026 16:48

joelhawksley mentioned this pull request Oct 9, 2026

before_render should respect render? #2718

Closed

Navigation Menu