Conversation
Add regression coverage and a demo for Link and Button graphics before stage attachment. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Run the shipped Link and Button renderer path in Bugserver. This keeps Issue #4836 covered in the browser bundle. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Wait for staged Link and Button graphics before reporting demo success. Expose the Bugserver case linkage for review traceability. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Assert Link and Button graphics survive attachment to a real VRender stage. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Expose the defining script URL so photo cases can reject stale helpers after switching versions. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Exercise the production helper through a real render lifecycle. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Keep the regression PR scoped to the reproducible unit test and demo. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Validate the intended ref lifecycle and fail incomplete readiness. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Prevent stale errors from leaking across Demo lifecycle runs. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Capture an immutable readiness run in each rendered callback. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LinkandButtoncustom-layout components can mount before their VRender graphics are attached to a stagenonechangeset because the production guard already exists indevelopThe regression was fixed incidentally by
1fadddcd13(feat: compatible react version 19), which changed directstage.renderNextFrame()calls to guarded calls. The new tests fail when those guards are reverted and pass on currentdevelop.Closes #4836
Test plan
rushx test --runInBandinpackages/react-vtable(3/3 tests)rushx compileinpackages/react-vtablerush build --only tag:packagerush test --only tag:packagesuite🤖 Generated with Claude Code