[codex] fix package build against VChart theme contracts#117
Merged
Conversation
VChart 2.x keeps tooltip mark/dimension on the component theme contract. Use IComponentTheme indexed access types to match the public API without changing theme content. Constraint: @visactor/vchart@2.0.22 exposes component theme contracts via IComponentTheme Rejected: Remove tooltip mark/dimension | VChart still consumes them from component.tooltip Confidence: high Scope-risk: narrow Directive: Type tooltip as IComponentTheme['tooltip'] when mark/dimension are present Tested: node common/scripts/install-run-rush.js build --only tag:package Tested: git diff --check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
IComponentTheme['tooltip']for the Aurora tooltip theme somarkanddimensionremain typed through the component theme contract.IComponentTheme['mapLabel']for the mobile map-label theme instead of importing a narrow type that VChart no longer exports..omx/state files.Why
The release build failed because VChart 2.x does not export
IMapLabelTheme, andITooltipThemeitself does not includemark/dimension. Local VChart source confirmsmarkanddimensionare still accepted functionally throughIComponentTheme['tooltip']and consumed by tooltip runtime logic.Validation
node common/scripts/install-run-rush.js build --only @visactor/vchart-aurora-theme --verbosenode ../../common/scripts/install-run-rushx.js compileinpackages/vchart-aurora-themenode common/scripts/install-run-rush.js build --only tag:packagegit diff --checkThe full package build completed with
SUCCESS WITH WARNINGS: 9 operations; warnings are existing Rollup/Browserslist/sourcemap warnings, not blocking build errors.