Repository navigation
Implement arc! primitive - #51
Merged
Merged
Conversation
jpthiele
force-pushed
the
arc_primitive
branch
from
October 10, 2026 19:10
a607226 to
7e23725
Compare
jpthiele
force-pushed
the
arc_primitive
branch
4 times, most recently
from
October 11, 2026 11:22
10ff02f to
08aa265
Compare
Contributor
Author
|
Btw: I have found an error in @j-fu FYI: If all tests pass now this PR is ready from my side |
j-fu
reviewed
Oct 11, 2026
jpthiele
force-pushed
the
arc_primitive
branch
from
October 11, 2026 20:01
08aa265 to
c10960d
Compare
Member
|
Looks good to me now. May be add a statement to the changelog. |
jpthiele
force-pushed
the
arc_primitive
branch
from
October 12, 2026 06:59
c10960d to
a703182
Compare
Contributor
Author
Check! And I rebased on current master so the changelog is up to date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new primitive for mesh construction.
With it we can now construct a set of faces whose points lie on a circle around the parameter
center.Important note:
This still needs some more testing and especially automated tests.
It works for the 'Plate with a hole', but there the center is the origin and both points lie in the first quadrant.
I'll try to work on some tests tomorrow, so as a note to me (and maybe someone else) I would test