Repository navigation
Local Grid Refinement: function unsuitable now can be used with only 2 arguments - #54
Conversation
pjaap
left a comment
There was a problem hiding this comment.
Thank you very much for this PR!
Can you please change the commented lines below and:
- set the Version in
Project.tomlto1.8.0
|
@j-fu what do you think? |
|
This is the idea with the callable struct: Then we can set |
41e277e to
6a36219
Compare
|
I see the problem with the I want to keep it very clean on the user side, so the CallableStruct is not a good idea. But what about something like opts_unsuitable = opts[:unsiutable]
function unsuitable(pa, pb, pc, pd)
if hasmethod(opts_unsuitable, Tuple{typeof(pa), typeof(pb), typeof(pc), typeof(pd)})
return opts_unsuitable(pa, pb, pc, pd)
else # assume two-argument function
center = ...
vol = ....
return opts_unsuitable(center, vol)
end
endfor TetGen ... and similar for Triangulate? |
|
|
6a36219 to
61991c0
Compare
…y 2 arguments it uses such arguments as barycentric coordiantes and area/volume. It work in both 2D and 3D. This unifies the signature for both 2D and 3D. New doc page has been added.
61991c0 to
e38b11a
Compare
Changes (from 14.10.2026):- Ideas from the discussion were implemented |
it uses such arguments as barycentric coordiantes and area/volume. It work in both 2D and 3D.
This unifies the signature for both 2D and 3D.
New doc page has been added.