Conversation
This refactoring prepares for a follow-on PR that will abstract how the module bytes are read from and written to the test and working files to support reducing Wasm modules embedded in JS files.
kripken
reviewed
Sep 18, 2026
| const std::vector<char>& bytes) { | ||
| Output out(filename, Flags::Binary); | ||
| out.write(bytes.data(), bytes.size()); | ||
| } |
Member
There was a problem hiding this comment.
If it is so useful to make a helper for this, should it be in support/file.h as a static function so other files can use it? (i.e. this doesn't seem more useful here than elsewhere)
kripken
reviewed
Sep 18, 2026
| if (result.failed()) { | ||
| return false; | ||
| } | ||
| outBytes = read_file<std::vector<char>>(testPath, Flags::Binary); |
Member
There was a problem hiding this comment.
i mean that we have read_file alreadyinfile.h, and write_file` may make sense too?
kripken
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactoring prepares for a follow-on PR that will abstract how the module bytes are read from and written to the test and working files to support reducing Wasm modules embedded in JS files.