Conversation
Add a function that will search JS source for literal byte arrays that might contain Wasm modules. Handle skipping strings and comments, and handle signed and unsigned byte values in decimal, octal, and hex formats. Reject byte arrays that do not begin with the Wasm magic values, but do not otherwise verify that the bytes encode a well-formed or valid Wasm module. Also add a function for printing a byte sequence as a JS byte array, formatted with 16 hex values per line. A future PR will use these functions in wasm-reduce to reduce Wasm modules embedded in JS files.
Member
|
This overlaps with https://github.com/WebAssembly/binaryen/blob/main/scripts/clusterfuzz/extract_wasms.py https://github.com/WebAssembly/binaryen/blob/main/scripts/clusterfuzz/embed_wasms.py Is there a strong reason to justify this duplication? |
Member
Author
|
No. It would make sense to deduplicate the logic. I would be happy to replace those scripts with a small new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a function that will search JS source for literal byte arrays that might contain Wasm modules. Handle skipping strings and comments, and handle signed and unsigned byte values in decimal, octal, and hex formats. Reject byte arrays that do not begin with the Wasm magic values, but do not otherwise verify that the bytes encode a well-formed or valid Wasm module.
Also add a function for printing a byte sequence as a JS byte array, formatted with 16 hex values per line.
A future PR will use these functions in wasm-reduce to reduce Wasm modules embedded in JS files.