Conversation
In the new mode, parse the input JS file to find all its embedded modules, then run a full reduction on each of them in sequence. Add a new JSTestCaseHandler that handles splicing the module bytes into the JS at the correct location. Reducing each module in sequence is simple, but in principle can miss reduction opportunities that would require changing multiple modules at once, for example reducing types that are used in inter-module communication. Its expected that the current implementation will be good enough in the common case.
tlively
requested review from
kripken and
stevenfontanella
and removed request for
a team
September 18, 2026 23:53
tlively
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the new mode, parse the input JS file to find all its embedded modules, then run a full reduction on each of them in sequence. Add a new JSTestCaseHandler that handles splicing the module bytes into the JS at the correct location. Reducing each module in sequence is simple, but in principle can miss reduction opportunities that would require changing multiple modules at once, for example reducing types that are used in inter-module communication. Its expected that the current implementation will be good enough in the common case.