Bump CMAKE_OSX_DEPLOYMENT_TARGET from 10.15 to 11.0 - #9129
Conversation
spotandjake
left a comment
spotandjake
left a comment
There was a problem hiding this comment.
Is this considered breaking? from my understanding this would drop support for some older versions of macos/xcode.
|
It would drop OSX >=10.15 <11.0 so yes |
|
@sbc100 do you perhaps know if this would break any of our builders? |
|
In emscripten-releases we already pass We do that same in emsdk.py: https://github.com/emscripten-core/emsdk/blob/a2b92777574c2feda07994cd4f1079a3dfc151f8/emsdk.py#L995 In wabt we still support 10.14, but I suppose to we can update that too: https://github.com/WebAssembly/wabt/blob/02418f72a70466b45805891843f114c7f602eb34/CMakeLists.txt#L27-L30 |
|
Please update the PR title to something like "Bump CMAKE_OSX_DEPLOYMENT_TARGET from 10.5 to 11.0". You can then describe the reason in more detail in the PR description |
Kara-Zor-El
changed the title
CMAKE_OSX_DEPLOYMENT_TARGET version to support macos 27
4 participants
macOS 27 / Xcode 27 changed the minimum required
CMAKE_OSX_DEPLOYMENT_TARGETfrom 10.15 to 11.0. In order to properly build on macOS 27, it is therefore needed to bump the minimum version.