Repository navigation
Conversation
Add constructors to `Function::DebugLocation` so `SmallVector::emplace_back` works without C++20 parenthesized aggregate initialization (which Clang added in 16, missing in Xcode 15.4 / Apple Clang 15 after #9400). Also mark `Node` and `SubtypeIterator` equality operators `const` to avoid `-Wambiguous-reversed-operator` under Clang 15. Add a `build-clang-15` job in `.github/workflows/ci.yml` on `ubuntu-22.04` with `-stdlib=libc++` to catch older Clang / `libc++` incompatibilities before they reach emsdk. Fixes: #9418
juj
reviewed
Nov 21, 2026
| - name: install dependencies | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y ninja-build clang-15 lld libc++-15-dev libc++abi-15-dev |
Collaborator
There was a problem hiding this comment.
Great to see clang-15 installable like this.. out of curiosity, are all clang versions generally available in this manner?
Member
Author
There was a problem hiding this comment.
For any given ubuntu release I think there will be several such clang versions, and it varies with ubuntu releases.
For example on my machine I can install clang-17 - clang-22, but not earlier versions.
juj
approved these changes
Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add constructors to
Function::DebugLocationsoSmallVector::emplace_backworks without C++20 parenthesized aggregate initialization (which Clang added in 16, missing in Xcode 15.4 / Apple Clang 15 after #9400). Also markNodeandSubtypeIteratorequality operatorsconstto avoid-Wambiguous-reversed-operatorunder Clang 15.Add a
build-clang-15job in.github/workflows/ci.ymlonubuntu-22.04with-stdlib=libc++to catch older Clang /libc++incompatibilities before they reach emsdk.Fixes: #9418