CABI: tighten subtask.cancel behavior again, add more tests - #726
Open
lukewagner wants to merge 1 commit into
Open
lukewagner wants to merge 1 commit into
lukewagner wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a further refinement of #723 based on some discussion with @dicej. To keep things simple, testable and symmetric with how async lower works,
subtask.cancelis returned to it's pre-#716 behavior where the only thread resumed duringsubtask.cancelis an implicitcallbackthread that's waiting in its event loop (which is the only way to receiveTASK_CANCELLEDatm) and then control flow deterministically transfers back as soon as thecallbackexits or blocks. This PR also adds a bunch of tests to confirm that nothing else is run instead of or after, and that, while running, coop-thread-switching is allowed.