Repository navigation
fix(setSinkId): use requested sink for resource acquisition - #2684
Open
whizzkid1452 wants to merge 3 commits into
Open
whizzkid1452 wants to merge 3 commits into
whizzkid1452 wants to merge 3 commits into
Conversation
mjwilson-google
requested changes
Oct 29, 2026
mjwilson-google
left a comment
mjwilson-google
left a comment
Member
There was a problem hiding this comment.
Thank you for looking into this.
Note that https://webaudio.github.io/web-audio-api/#AudioContext-constructors also wasn't updated to explicitly handle type "none"; if you have time to update that algorithm too it would be appropriate to include in this PR.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sinkIdwhen acquiring resources duringAudioContext.setSinkId()instead of the current[[sink ID]]slot.AudioSinkOptionstype: nonetarget in the acquisition cases.die-on=nothingto the PR Preview Bikeshed parameters for future previews that use the updated base configuration.Test plan
git diff --checkpassed with only the repository's existing Windows line-ending warning.die-on=nothingis added.die-on=nothingfrom this PR's generated URL, which indicates it is using the base branch preview configuration.