Service worker preload support - #540
Open
camillobruni wants to merge 65 commits into
Open
Conversation
camillobruni
marked this pull request as draft
June 10, 2026 15:42
✅ Deploy Preview for webkit-speedometer-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for webkit-speedometer-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
# Conflicts: # experimental/javascript-wc-indexeddb/dist/src/speedometer-utils/test-invoker.mjs # experimental/javascript-wc-indexeddb/dist/src/speedometer-utils/test-runner.mjs # resources/suite-runner.mjs # suites-experimental/javascript-wc-indexeddb/dist/resources.txt # suites-experimental/javascript-wc-indexeddb/dist/src/speedometer-utils/step-runner.mjs # suites-experimental/javascript-wc-indexeddb/dist/src/speedometer-utils/step-scheduler.mjs # suites-experimental/javascript-wc-indexeddb/dist/src/speedometer-utils/test-invoker.mjs # suites-experimental/javascript-wc-indexeddb/dist/src/speedometer-utils/test-runner.mjs # suites-experimental/responsive-design/dist/resources.txt # suites-experimental/suites.mjs # suites-experimental/todomvc-dart-jaspr/dist/out-dart2js-O4/resources.txt # suites-experimental/todomvc-dart-jaspr/dist/out-dart2wasm-O2/resources.txt # suites-experimental/todomvc-localstorage/dist/base.css # suites-experimental/todomvc-localstorage/dist/index.css # suites-experimental/todomvc-localstorage/dist/resources.txt # suites-experimental/todomvc-localstorage/src/resources.txt # suites/charts/dist/resources.txt # suites/default-suites.mjs # suites/editors/dist/resources.txt # suites/newssite/news-next/dist/resources.txt # suites/newssite/news-next/public/resources.txt # suites/react-stockcharts/build/resources.txt # suites/todomvc/architecture-examples/angular-complex/dist/resources.txt # suites/todomvc/architecture-examples/angular/dist/resources.txt # suites/todomvc/architecture-examples/backbone-complex/dist/resources.txt # suites/todomvc/architecture-examples/backbone/dist/resources.txt # suites/todomvc/architecture-examples/jquery-complex/dist/resources.txt # suites/todomvc/architecture-examples/jquery/dist/resources.txt # suites/todomvc/architecture-examples/lit-complex/dist/resources.txt # suites/todomvc/architecture-examples/lit/dist/resources.txt # suites/todomvc/architecture-examples/preact-complex/dist/resources.txt # suites/todomvc/architecture-examples/preact/dist/resources.txt # suites/todomvc/architecture-examples/react-complex/dist/resources.txt # suites/todomvc/architecture-examples/react-redux-complex/dist/resources.txt # suites/todomvc/architecture-examples/react-redux/dist/resources.txt # suites/todomvc/architecture-examples/react/dist/resources.txt # suites/todomvc/architecture-examples/svelte-complex/dist/resources.txt # suites/todomvc/architecture-examples/svelte/dist/resources.txt # suites/todomvc/architecture-examples/vue-complex/dist/resources.txt # suites/todomvc/architecture-examples/vue/dist/resources.txt # suites/todomvc/big-dom-generator/dist/resources.txt # suites/todomvc/todomvc-css/dist/resources.txt # suites/todomvc/vanilla-examples/javascript-es5-complex/dist/resources.txt # suites/todomvc/vanilla-examples/javascript-es6-webpack-complex/dist/resources.txt # suites/todomvc/vanilla-examples/javascript-es6-webpack/dist/resources.txt # suites/todomvc/vanilla-examples/javascript-web-components-complex/dist/resources.txt # suites/todomvc/vanilla-examples/javascript-web-components/dist/resources.txt # tests/run-end2end.mjs
camillobruni
changed the title
camillobruni
marked this pull request as ready for review
August 18, 2026 09:54
This fixes a race condition where SpeedometerReady would fire while _preloadResources was still in flight asynchronously. That caused the test runner to simultaneously invoke benchmarkClient.start(), leading to concurrent preloads that randomly caused the PRELOAD_SUITES message to resolve a STOP_PRELOADING promise incorrectly on slower browsers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.