Fix innerHTML/innerText to coerce non-string values - #333
Open
dyk1454683243-sudo wants to merge 1 commit into
Open
dyk1454683243-sudo wants to merge 1 commit into
dyk1454683243-sudo wants to merge 1 commit into
Conversation
Browsers stringify assignments (null → ''). Setting a number no longer throws; innerText now has a matching setter that replaces text content. Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #308
Setting
innerHTMLorinnerTextwith a non-string (for example1ornull) currently throws. Browsers treat these accessors as[LegacyNullToEmptyString] DOMString:nullbecomes'', and any other value is stringified.This keeps the change on the setter path only:
setInnerHtmlcoerces withhtml === null ? '' : String(html)beforeparseFromStringElementnow has a matchingset innerTextthat uses the same coerce and replaces children liketextContent(the existingget innerTextwhitespace rules are unchanged)innerHTML = 1,innerHTML = null, andinnerText = 1