Treat DOMTokenList.toggle undefined force as omitted - #334
Open
dyk1454683243-sudo wants to merge 1 commit into
Open
dyk1454683243-sudo wants to merge 1 commit into
dyk1454683243-sudo wants to merge 1 commit into
Conversation
Web IDL optional boolean means toggle(token, undefined) must plain-toggle like a one-argument call, not coerce undefined to false. Fixes WebReflection#277 Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
dyk1454683243-sudo
marked this pull request as ready for review
September 20, 2026 05:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #277
DOMTokenList.toggle(token, force)now treatsforce === undefinedlike an omitted second argument (plain toggle), matching browsers and Web IDL optional boolean.undefinedforce → add (same as one-argtoggle)undefinedforce → removeforcetrue/falsestill force-add / force-removeFocused change in
esm/dom/token-list.js(CJS mirrored) plus regression tests.