Skip to content

Make issue-draft summaries compact and byte-budgeted - #5069

Merged
Widthdom merged 4 commits into
mainfrom
fix-issue5058
Aug 10, 2026
Merged

Make issue-draft summaries compact and byte-budgeted#5069
Widthdom merged 4 commits into
mainfrom
fix-issue5058

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

  • Add a dedicated compact DTO for recipe/audit issue-draft summaries so full recipe definitions, rendered issue bodies, and source rows are not repeated.
  • Enforce --max-json-bytes against the complete UTF-8 JSON document including its final newline, omitting only whole summary rows and returning typed E028 guidance when the envelope cannot fit.
  • Preserve positive-query and evidence-path accounting across --limit / --total-limit, with explicit authority and lower-bound metadata plus uncapped recovery commands.
  • Preserve the full issue-draft output contract and the invoked search versus audit identity.

Validation

  • dotnet build CodeIndex.sln -c Release --no-restore -p:UseSharedCompilation=false — passed with 0 warnings and 0 errors on the final branch.
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-restore --no-build --filter FullyQualifiedName~RunSearch_RecipeIssueDraft — 8/8 passed on both net8.0 and net9.0 after the final review fixes.
  • Full Release suite on the implementation baseline — net8.0: 11,226 passed, 7 skipped; net9.0: 10,760 passed, 412 skipped; 0 failed.
  • dotnet format CodeIndex.sln --verify-no-changes --no-restore — passed.
  • dotnet run --project tools/CodeIndex.Changelog -- check — passed.
  • The Issue Make issue-draft summary output genuinely compact and byte-budgeted #5058 reproduction now exits successfully within the 120,000-byte budget.
  • Final cdidx index . --commits HEAD --json and cdidx status --check --json completed with 0 warnings/errors and a clean, current index.

Documentation and changelog

Review

  • Ran the repository-required Codex adversarial review for two rounds.
  • Round 1 findings (bounded count semantics and missing testing documentation) were fixed.
  • Round 2 findings (positive queries hidden by --total-limit and pre-limit evidence-path accounting) were fixed and covered by passing regression tests. The workflow's two-round review cap was respected.

Follow-ups

  • None.

Fixes #5058

@Widthdom
Widthdom marked this pull request as ready for review August 10, 2026 12:10
@Widthdom
Widthdom merged commit 65bc8b1 into main Aug 10, 2026
12 checks passed
@Widthdom
Widthdom deleted the fix-issue5058 branch August 10, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make issue-draft summary output genuinely compact and byte-budgeted

1 participant