Make issue-draft summaries compact and byte-budgeted - #5069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--max-json-bytesagainst the complete UTF-8 JSON document including its final newline, omitting only whole summary rows and returning typedE028guidance when the envelope cannot fit.--limit/--total-limit, with explicit authority and lower-bound metadata plus uncapped recovery commands.searchversusauditidentity.Validation
dotnet build CodeIndex.sln -c Release --no-restore -p:UseSharedCompilation=false— passed with 0 warnings and 0 errors on the final branch.dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-restore --no-build --filter FullyQualifiedName~RunSearch_RecipeIssueDraft— 8/8 passed on both net8.0 and net9.0 after the final review fixes.dotnet format CodeIndex.sln --verify-no-changes --no-restore— passed.dotnet run --project tools/CodeIndex.Changelog -- check— passed.cdidx index . --commits HEAD --jsonandcdidx status --check --jsoncompleted with 0 warnings/errors and a clean, current index.Documentation and changelog
USER_GUIDE.md,DEVELOPER_GUIDE.md, andTESTING_GUIDE.md.changelog.d/unreleased/5058.fixed.md, referencing Make compact output controls easier to discover and apply consistently across audit and recipe workflows #4064, Add compact metadata controls for audit issue-drafts output #4118, and Add compact bulk-triage modes for audit/search count and issue-draft outputs #4308.Review
countsemantics and missing testing documentation) were fixed.--total-limitand pre-limit evidence-path accounting) were fixed and covered by passing regression tests. The workflow's two-round review cap was respected.Follow-ups
Fixes #5058