remove OptimizedWorldTileEntitySet#133
Open
kalibrieren wants to merge 2 commits into
Open
Conversation
fixes spawn rates
fixes spawn rates
|
|
||
| // Entities that do a scanPlayer# lookup, helps to slow down. | ||
| this.put(TileEntityEnchantTable.class, 20L); | ||
| this.put(TileEntityMobSpawner.class, 20L); |
Member
There was a problem hiding this comment.
Nice work spotting the issue. But do we have to remove these optimizations entirely?
We could just delete this line and not register a custom interval, which would restore vanilla behavior. Or better we could make these configurable.
Author
There was a problem hiding this comment.
The performance difference is negligible.
I think it's better to remove it as most of the TileEntities have their tick methods cleared anyway.
Also, we should search for better optimizations instead of continuing to use these dirty ones that break vanilla expectations.
Member
There was a problem hiding this comment.
Makes sense. I assume you've tested it and everything is working ok?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes spawn rates