Skip to content
This repository was archived by the owner on Aug 11, 2026. It is now read-only.

Hide Chrome development flag warning and patch PHPCS - #219

Merged
ashfame merged 2 commits into
agent/maintenance-security-and-hygienefrom
agent/chrome-test-type
Aug 11, 2026
Merged

Hide Chrome development flag warning and patch PHPCS#219
ashfame merged 2 commits into
agent/maintenance-security-and-hygienefrom
agent/chrome-test-type

Conversation

@ashfame

@ashfame ashfame commented Aug 11, 2026

Copy link
Copy Markdown
Member

Summary

Add Chrome's --test-type launch flag to both the development runner and production-preview runner.

web-ext injects --disable-blink-features=AutomationControlled so its CDP-driven Chrome instance does not expose navigator.webdriver = true. Chrome displays a generic unsupported-command-line-flag banner for that development-only browser; --test-type suppresses the banner while retaining the behavior required by web-ext.

Refresh the locked PHP_CodeSniffer patch from 3.13.5 to 3.13.6. A high-severity command-injection advisory published after PR #199's previous validation caused its Composer audit gate to fail; 3.13.6 is the first patched release on the retained major.

Impact

The browser change affects only temporary Chrome instances launched by local npm development commands. It does not alter either packaged extension, Firefox behavior, or regular browser sessions. The Composer change is limited to the patched PHPCS development-tool lock entry.

Validation

  • Installed the exact lock on Node 24.18.1 with npm 11.16.0 using npm ci --ignore-scripts.
  • Confirmed web-ext accepts both repeated --arg values.
  • Ran npm run build:chrome; all three webpack targets compiled with only the existing Playground dynamic-dependency warning.
  • Confirmed Composer changed only squizlabs/php_codesniffer from 3.13.5 to 3.13.6.
  • Ran composer audit --locked; no security advisories remain.
  • Ran composer run lint; PHP CodeSniffer passed.
  • Ran git diff --check.

@ashfame ashfame changed the title Hide Chrome development flag warning Hide Chrome development flag warning and patch PHPCS Aug 11, 2026
@ashfame
ashfame merged commit 78dc611 into agent/maintenance-security-and-hygiene Aug 11, 2026
5 checks passed
@ashfame
ashfame deleted the agent/chrome-test-type branch August 11, 2026 10:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant