Skip to content

Administration: Improve the highlight styling of newly added Quick Drafts#12316

Open
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:fix/65539-quick-draft-highlight-color
Open

Administration: Improve the highlight styling of newly added Quick Drafts#12316
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:fix/65539-quick-draft-highlight-color

Conversation

@itzmekhokan

Copy link
Copy Markdown

When a new draft is created via the Quick Draft dashboard widget, the entry added to "Your Recent Drafts" is briefly highlighted for one second. This change improves that highlight's color and spacing.

What the problem was

  • The highlight used a faint yellow background (#fffbe5), applied inline via JavaScript.
  • The yellow predates the current admin color scheme, is barely visible, and is inconsistent with other success feedback in the admin (e.g. the Recent Comments widget uses green when approving a comment or undoing a spam action).
  • The highlight hugged the text with no breathing room (no padding).

What the fix does

  • Applies the highlight via a highlighted-draft CSS class instead of an inline style (separation of concerns; removes the odd background: none reset).
  • Uses the success green #ceb already used elsewhere in the admin (edit-comments.js) for positive confirmations, so success feedback is visually consistent — this is the exact color referenced in the ticket.
  • Makes the highlight span the full width of the widget with internal padding, matching the dashboard widget style, so it reads as a proper success row with breathing room.
  • Negative margins offset the padding so surrounding drafts do not shift while the highlight is shown (no layout jank).

Approach and why

  • #ceb is the only existing "success" background-highlight green in core admin code and is precisely what the ticket cites for consistency. (Written as shorthand #ceb per the WordPress CSS Coding Standards.)
  • The full-bleed band aligns with the widget's existing full-width separator (border-top) and 12px content inset, keeping it on-style with the rest of the Quick Draft widget.

Trac ticket: https://core.trac.wordpress.org/ticket/65539

Use of AI Tools

N/A


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…afts.

When a new draft is created via the Quick Draft dashboard widget, the
entry added to "Your Recent Drafts" is briefly highlighted. Previously
the highlight used a faint yellow background (#fffbe5) applied inline,
which predates the current admin color scheme, is barely visible, and is
inconsistent with other success feedback in the admin. The highlight also
hugged the text with no breathing room.

Apply the highlight via a `highlighted-draft` class instead of an inline
style, and style it in CSS to:

* Use the green (#ceb) already used for success confirmations elsewhere,
  such as the Recent Comments widget when approving a comment or undoing
  a spam action, so success feedback is visually consistent.
* Span the full width of the widget with internal padding, matching the
  dashboard widget style, so the highlight reads as a proper success row
  with breathing room around the text.

Negative margins offset the padding so surrounding drafts do not shift
while the highlight is shown.

Fixes #65539.
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props khokansardar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Hi there! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant