Skip to content

HTML API: Ensure attribute value prefixes match entire search string#12380

Open
sirreal wants to merge 17 commits into
WordPress:trunkfrom
sirreal:fix/html-decoder-attribute-prefix-match
Open

HTML API: Ensure attribute value prefixes match entire search string#12380
sirreal wants to merge 17 commits into
WordPress:trunkfrom
sirreal:fix/html-decoder-attribute-prefix-match

Conversation

@sirreal

@sirreal sirreal commented Jul 1, 2026

Copy link
Copy Markdown
Member

Ensure that a shorter haystack does not match a longer prefix when searching for prefix matches:

var_dump( WP_HTML_Decoder::attribute_starts_with( 'm', 'matchme' ) );
// bool(true)
var_dump( WP_HTML_Decoder::attribute_starts_with( '', 'empty always matches' ) );
// bool(true)

Trac ticket: https://core.trac.wordpress.org/ticket/65372

Use of AI Tools

AI assistance: Yes
Tool(s): Codex
Model(s): GPT-5.5
Used for: Fuzz testing, diagnosis, implementation, review.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Hi there! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@sirreal sirreal marked this pull request as ready for review July 1, 2026 16:01
@sirreal sirreal requested a review from dmsnell July 1, 2026 16:01
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell, dmsnell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

continue;
}

// If there is a character reference, then the decoded value must exactly match what follows in the search string.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs an illustrative comment showing when and why we are using min()

the fj/f example is a good one. attribute value contains fj, search prefix is f, decoded is fj

Comment thread tests/phpunit/tests/html-api/wpHtmlDecoder.php Outdated
// If there is a character reference, then the decoded value must exactly match what follows in the search string.
if ( 0 !== substr_compare( $search_text, $next_chunk, $search_at, strlen( $next_chunk ), $loose_case ) ) {
$match_length = min( strlen( $next_chunk ), $search_length - $search_at );
if ( 0 !== substr_compare( $search_text, $next_chunk, $search_at, $match_length, $loose_case ) ) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this logic be clearer and still held if, instead of adjusting numbers here, that we cut the $next_chunk short if if the prefix length plus its own length is beyond the search/needle length?

that is, if we have fi as the replacement, but the search length is one less than that, we would simply $next_chunk = $length_okay ? $next_chunk : substr( $next_chunk, 0, $max_length )?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants