HTML API: Ensure attribute value prefixes match entire search string#12380
HTML API: Ensure attribute value prefixes match entire search string#12380sirreal wants to merge 17 commits into
Conversation
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| continue; | ||
| } | ||
|
|
||
| // If there is a character reference, then the decoded value must exactly match what follows in the search string. |
There was a problem hiding this comment.
this needs an illustrative comment showing when and why we are using min()
the fj/f example is a good one. attribute value contains fj, search prefix is f, decoded is fj
| // If there is a character reference, then the decoded value must exactly match what follows in the search string. | ||
| if ( 0 !== substr_compare( $search_text, $next_chunk, $search_at, strlen( $next_chunk ), $loose_case ) ) { | ||
| $match_length = min( strlen( $next_chunk ), $search_length - $search_at ); | ||
| if ( 0 !== substr_compare( $search_text, $next_chunk, $search_at, $match_length, $loose_case ) ) { |
There was a problem hiding this comment.
would this logic be clearer and still held if, instead of adjusting numbers here, that we cut the $next_chunk short if if the prefix length plus its own length is beyond the search/needle length?
that is, if we have fi as the replacement, but the search length is one less than that, we would simply $next_chunk = $length_okay ? $next_chunk : substr( $next_chunk, 0, $max_length )?
Ensure that a shorter haystack does not match a longer prefix when searching for prefix matches:
Trac ticket: https://core.trac.wordpress.org/ticket/65372
Use of AI Tools
AI assistance: Yes
Tool(s): Codex
Model(s): GPT-5.5
Used for: Fuzz testing, diagnosis, implementation, review.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.