Skip to content

Administration: Normalize texturized post search terms #12451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ArkaPrabhaChowdhury wants to merge 2 commits into
base: trunk
Choose a base branch
from
+56 −0
Draft

Administration: Normalize texturized post search terms #12451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a7d393
Administration: Normalize texturized post search terms
ArkaPrabhaChowdhury Jul 8, 2026
d65e45f
Tests: Remove extra blank line at end of search query test file
ArkaPrabhaChowdhury Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/wp-includes/class-wp-query.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1440,6 +1440,26 @@ protected function parse_search( &$query_vars ) {
if ( empty( $_GET['s'] ) && $this->is_main_query() ) {
$query_vars['s'] = urldecode( $query_vars['s'] );
}
// Admin post titles are texturized before display, so copied smart quotes should still match stored titles.
$query_vars['s'] = strtr(
$query_vars['s'],
array(
"\u{00A0}" => ' ',
"\u{202F}" => ' ',
"\u{00AB}" => '"',
"\u{00BB}" => '"',
"\u{2018}" => "'",
"\u{2019}" => "'",
"\u{201A}" => "'",
"\u{201B}" => "'",
"\u{201C}" => '"',
"\u{201D}" => '"',
"\u{201E}" => '"',
"\u{201F}" => '"',
"\u{2039}" => "'",
"\u{203A}" => "'",
)
);
// There are no line breaks in <input /> fields.
$query_vars['s'] = str_replace( array( "\r", "\n" ), '', $query_vars['s'] );
$query_vars['search_terms_count'] = 1;
Expand Down
36 changes: 36 additions & 0 deletions tests/phpunit/tests/query/search.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ private function get_search_results( $terms ) {
return $this->q->query( $args );
}

private function get_texturized_search_term( $title ) {
return html_entity_decode( wptexturize( $title ), ENT_QUOTES, 'UTF-8' );
}

public function test_search_order_title_relevance() {
foreach ( range( 1, 7 ) as $i ) {
self::factory()->post->create(
Expand All @@ -52,6 +56,38 @@ public function test_search_order_title_relevance() {
$this->assertSame( $post_id, reset( $posts )->ID );
}

/**
* @ticket 63209
*/
public function test_search_should_match_texturized_double_quotes() {
$post_id = self::factory()->post->create(
array(
'post_title' => '"New" a good post',
'post_type' => $this->post_type,
)
);

$posts = $this->get_search_results( $this->get_texturized_search_term( '"New" a good post' ) );

$this->assertSame( array( $post_id ), wp_list_pluck( $posts, 'ID' ) );
}

/**
* @ticket 63209
*/
public function test_search_should_match_texturized_apostrophes() {
$post_id = self::factory()->post->create(
array(
'post_title' => "Today's post",
'post_type' => $this->post_type,
)
);

$posts = $this->get_search_results( $this->get_texturized_search_term( "Today's post" ) );

$this->assertSame( array( $post_id ), wp_list_pluck( $posts, 'ID' ) );
}

public function test_search_terms_query_var() {
$terms = 'This is a search term';
$query = new WP_Query( array( 's' => 'This is a search term' ) );
Expand Down
Loading