Privacy: Surface email-send failures when initiating a personal data request - #12923
Privacy: Surface email-send failures when initiating a personal data request#12923irozum wants to merge 2 commits into
Conversation
…rsonal_data_handle_actions()
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
What: When an admin adds a new personal data export/erasure request with "send confirmation email" checked,
_wp_personal_data_handle_actions()callswp_send_user_request()but discards its return value, then unconditionally shows "Confirmation request initiated successfully." Sincewp_send_user_request()returns aWP_Erroron mail failure, the admin gets a false success message even when the confirmation email never went out — leaving the request stuck pending with no obvious explanation.Fix: Check the return value of
wp_send_user_request()and, if it's aWP_Error, surface the actual error message viaadd_settings_error()(typeerror) instead of the canned success string — mirroring the existing pattern used a few lines above forwp_create_user_request()failures and in_wp_privacy_resend_request()'s retry path.Tests: Added
tests/phpunit/tests/privacy/wpPersonalDataHandleActions.php, covering both the failure path (forcingwp_mail()to fail via thewp_mail_fromfilter, per the existing pattern inTests_User_wpSendUserRequest) and the existing success path as a regression guard.Trac ticket: https://core.trac.wordpress.org/ticket/54442
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5
Used for: Implementation, tests, and PR description. Reviewed by Igor Rozum.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.